feat: odigos describe sub commands for auto completion #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yodigos
reviewed
Jul 31, 2024
yodigos
reviewed
Jul 31, 2024
yodigos
reviewed
Jul 31, 2024
yodigos
reviewed
Jul 31, 2024
|
|
||
| if len(args) != 2 { | ||
| fmt.Println("Usage: odigos describe <kind> <name>") | ||
| deployment, err := client.AppsV1().Deployments(ns).Get(ctx, name, metav1.GetOptions{}) |
There was a problem hiding this comment.
I see this function happens also at sources.go, login.go, uninstall.go.
Maybe we can create a util file and put the function over there.
Your call..
There was a problem hiding this comment.
Since it's just one line, I prefer to use the k8s client directly and not introduce more complexity to the code
yodigos
reviewed
Jul 31, 2024
| return | ||
| } | ||
| workloadObj := &K8sSourceObject{ | ||
| Kind: "deployment", |
There was a problem hiding this comment.
Not sure but I think deployment.Kind returns this string.
Also other places
There was a problem hiding this comment.
Unfortunately, The Kind property is not populated by the client when instantiating a Deployment object. This is why I needed to add it explicitly
yodigos
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.