feat: Fe onboarding flow #1427
Merged
feat: Fe onboarding flow #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yodigos
force-pushed
the
fe-onboarding-flow
branch
from
12aa6ec to
6027742
Compare
alonkeyval
reviewed
Aug 6, 2024
alonkeyval
reviewed
Aug 6, 2024
alonkeyval
reviewed
Aug 6, 2024
| // Fill Destination Form | ||
| cy.url().should('eq', 'http://localhost:3000/connect-destination?type=tempo'); | ||
| cy.get('[data-cy=create-destination-input-name]').type('e2e-tests'); | ||
| cy.get('[data-cy=create-destination-input-endpoint]').type('e2e-tests-tempo.traces:4317'); |
There was a problem hiding this comment.
this is async render after the data return from the server, maybe we need to wait for this?
There was a problem hiding this comment.
There is a default timeout Cypress for this
alonkeyval
reviewed
Aug 6, 2024
frontend/webapp/components/setup/connection/create.connection.form/create.connection.form.tsx
Show resolved
Hide resolved
alonkeyval
reviewed
Aug 6, 2024
frontend/webapp/components/setup/connection/create.connection.form/dynamic.fields.tsx
Outdated
Show resolved
Hide resolved
alonkeyval
reviewed
Aug 6, 2024
alonkeyval
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.