test: add e2e test for odigos cli upgrade from latest to HEAD #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blumamir
changed the title
blumamir
commented
Aug 16, 2024
| fmt.Println("Odigos upgrade failed - unable to read the current Odigos version for migration") | ||
| os.Exit(1) | ||
| } | ||
| if !cmd.Flag("skip-version-check").Changed { |
There was a problem hiding this comment.
the change here is adding this new flag since the current upgrade behavior requires a valid formatted version v1.2.3 while the tests use the tag e2e-test. this flag allows the test to bypass the checks
blumamir
commented
Aug 16, 2024
| spec: | ||
| containers: | ||
| - name: manager | ||
| image: keyval/odigos-autoscaler:e2e-test |
There was a problem hiding this comment.
review note: i tested it locally once with an illegal tag value keyval/odigos-autoscaler:illegal to make sure this is asserted correctly and it does
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since odigos upgrade is a potentially sensative process which can fail for various reasons, this PR adds an e2e test that starts with the latest odigos version from github, and then calls cli upgrade to the current version in HEAD.
Then it generates traffic and verify that traces are created.