refactor: cleanups for k8sutils workload package. create enums and move common functions #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonFed
reviewed
Aug 17, 2024
| return err | ||
| } | ||
|
|
||
| func WorkloadKindLowerCaseFromKind(pascalCase WorkloadKind) WorkloadKindLowerCase { |
There was a problem hiding this comment.
It is equivalent to strings.ToLower. I'm not sure why we need types for both pascal and lowercase. We can have just the pascal one and use ToLower when needed in the utils functions
There was a problem hiding this comment.
yes, since it's used in several places, I choose to have a type for it as enum
RonFed
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another step in the way to move everything related to common things into the common packages, and avoid duplications and untyped usages in the project.
This PR:
workloadpackage in k8sutils to differentiate between the different utils and enumsThere are countless places to go over and improve. This PR is touching on the most easy and straight forward cases I spotted.