Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: otel sdk instrumentation rule #1499

Merged
merged 4 commits into from
Sep 14, 2024
Merged

Conversation

blumamir
Copy link
Collaborator

@blumamir blumamir commented Sep 14, 2024

Add a instrumentation rule which allows to configure the SDKs to use.

This replaces the need to use odigos-config which must be applied as a whole which is inconvenient and error prone.

By using the new instrumentation rule, one can specify the usecase in a separate manifest, and gain more flexibility on how it is applied (workloads list, languages, multiple levels, etc)

Copy link
Contributor

@edeNFed edeNFed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blumamir blumamir merged commit 228f166 into odigos-io:main Sep 14, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants