Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross cloud providers tests #1583

Merged
merged 67 commits into from
Oct 21, 2024

Conversation

tamirdavid1
Copy link
Collaborator

No description provided.

@tamirdavid1 tamirdavid1 force-pushed the cross-cloud-providers-tests branch from 2ca1763 to bfe2000 Compare October 13, 2024 08:03
@tamirdavid1 tamirdavid1 force-pushed the cross-cloud-providers-tests branch from 6b5c629 to c2213b7 Compare October 20, 2024 10:45
Copy link
Contributor

@edeNFed edeNFed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, maybe we should setup some TTL or something on the ECR registry so images are deleted after some time?

Copy link
Collaborator

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

.github/workflows/cross-cloud-tests.yaml Outdated Show resolved Hide resolved
.github/workflows/cross-cloud-tests.yaml Outdated Show resolved Hide resolved
Comment on lines 89 to 94
# Wait for the pods to be ready
kubectl wait --for=condition=ready pod -l app=frontend --timeout=50s
kubectl wait --for=condition=ready pod -l app=coupon --timeout=50s
kubectl wait --for=condition=ready pod -l app=inventory --timeout=50s
kubectl wait --for=condition=ready pod -l app=membership --timeout=50s
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't it taken care of by assert-apps-installed.yaml?

tests/e2e/helm-chart/chainsaw-test.yaml Show resolved Hide resolved
@tamirdavid1 tamirdavid1 force-pushed the cross-cloud-providers-tests branch from d3b1006 to c0b29af Compare October 21, 2024 13:09
@tamirdavid1 tamirdavid1 force-pushed the cross-cloud-providers-tests branch from 8253ccf to beb6826 Compare October 21, 2024 13:11
@tamirdavid1 tamirdavid1 force-pushed the cross-cloud-providers-tests branch from ff662b9 to f723b20 Compare October 21, 2024 13:13
@tamirdavid1 tamirdavid1 merged commit 421987d into odigos-io:main Oct 21, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants