Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEN-1535]: beginners guide #1604

Merged
merged 5 commits into from
Oct 22, 2024

Conversation

BenElferink
Copy link
Contributor

No description provided.

Copy link

@BenElferink BenElferink requested a review from blumamir October 20, 2024 12:46
@@ -12,8 +12,8 @@ The documentation is build on [Mintlify](https://www.npmjs.com/package/mintlify)

```
# make sure you're in `/docs` folder, where `mint.json` and `package.json` files are
npm ci
npm run dev
npm i -g mintlify
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about the -g flag, should it be global?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mintlify in-repo isn't working as expected because of "sharp".
A global installation of mintlify allows us to use the command without relying on repo-dependencies that cause it to break.

@alonkeyval alonkeyval self-requested a review October 20, 2024 13:20
Copy link
Collaborator

@alonkeyval alonkeyval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenElferink BenElferink enabled auto-merge (squash) October 22, 2024 11:46
@BenElferink BenElferink merged commit b302071 into odigos-io:main Oct 22, 2024
26 checks passed
@BenElferink BenElferink deleted the gen-1535-beginners-guide branch December 28, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants