Remove default SDKs and supported SDKs from Odigos config #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonFed
changed the title
blumamir
approved these changes
Oct 27, 2024
Comment on lines
-48
to
-49
| SupportedSDKs map[common.ProgrammingLanguage][]common.OtelSdk `json:"supportedSDKs,omitempty"` | ||
| DefaultSDKs map[common.ProgrammingLanguage]common.OtelSdk `json:"defaultSDKs,omitempty"` |
| }, | ||
| APIGroups: []string{""}, | ||
| Resources: []string{ | ||
| "secrets", |
There was a problem hiding this comment.
I think it's good for now.
In the future, we might want to consider storing the tier in the odigos-deployment configmap, so we can read the tier easily without needing permissions to secrets. We can also use envFrom to automatically have these as env variables in the code
RonFed
pushed a commit
that referenced
this pull request
Nov 9, 2024
This controller was relevant when the defaultSdks were read from the odigos config. Once it's removed in #1626 , now the instrumentor read the default sdks based on the tier on boot, and no longer consumes it from this config map. Notice that any change in tier will not be picked up automatically to update the device names (was not supported before this PR).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the default SDKs from odigos config.
The updated way of changing instrumentation SDK is with rules and profiles.
This change includes:
getsecrets in odigos ns.envtestfor env overwriter - instead of reading writing to mock ofodigosconfig- mock the default SDK for the new code and simulate a changing SDK by mocking instrumentation rule.