-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEN-1691] load styled on server #1725
Merged
alonkeyval
merged 449 commits into
odigos-io:new-ui
from
alonkeyval:gen1691-load-style-on-server
Nov 10, 2024
Merged
[GEN-1691] load styled on server #1725
alonkeyval
merged 449 commits into
odigos-io:new-ui
from
alonkeyval:gen1691-load-style-on-server
Nov 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[GEN-1100] chore: setup choose source
[GEN-1110] chore: get all sources of a namespace
[GEN-1203] chore: select sources
[GEN-1124] chore: get destination list
[GEN-1117] feat: reusable modal component
[GEN-1503] feat: edit destination
…factor [GEN-1538] Refactor destinations types query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
frontend/webapp
directory, focusing on refactoring the theme provider, adding a new header component, and updating the layout file to use the new theme provider. The most important changes are summarized below:Refactoring and Theming:
ThemeProvider
withThemeProviderWrapper
infrontend/webapp/app/layout.tsx
to encapsulate the theme and styled-components registry. [1] [2]palette.ts
file and moved theme-related code totheme-provider/index.tsx
. [1] [2]StyledComponentsRegistry
for server-side rendering of styled-components.Component Additions:
SetupHeader
component infrontend/webapp/components/setup/header/index.tsx
for the setup page header.index.tsx
file infrontend/webapp/components/setup
to export the newSetupHeader
component.File Organization:
frontend/webapp/styles/index.ts
to export the newtheme-provider
module instead of the oldpalette
.