Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GEN-1781]: fix state of "recordedRows" in "monitors" checkbox list #1816

Merged
merged 180 commits into from
Nov 21, 2024
Merged

[GEN-1781]: fix state of "recordedRows" in "monitors" checkbox list #1816

merged 180 commits into from
Nov 21, 2024

Conversation

BenElferink
Copy link
Contributor

No description provided.

BenElferink and others added 30 commits October 20, 2024 05:28
@BenElferink
Merge pull request #1 from odigos-io/main
c25c631 
merge main
@alonkeyval
Refactor old ui to new product design (odigos-io#1605)
12046ba
@BenElferink
Merge remote-tracking branch 'odigos/new-ui' into gen-1511-new-ui
6037f4c
@alonkeyval
[GEN-1539] Refactor action api to gql (odigos-io#1606)
62934de
@alonkeyval
[GEN-1540] Add update action mutation (odigos-io#1607)
d456363 
This pull request includes several changes to improve the handling of
action types in the `CreateAction` and `UpdateAction` resolvers, as well
as the addition of a new update function for `AddClusterInfo` actions.
The most important changes involve refactoring action type strings into
constants and implementing the `UpdateAddClusterInfo` function.

### Refactoring action types:

*
[`frontend/graph/schema.resolvers.go`](diffhunk://#diff-8e6e95029056db2c0301fc338e0ca5a04356ce5d45ee9514bbd167f2d85bae70L560-R560):
Replaced hardcoded action type strings with constants from
`actionservices` for better maintainability.
[[1]](diffhunk://#diff-8e6e95029056db2c0301fc338e0ca5a04356ce5d45ee9514bbd167f2d85bae70L560-R560)
[[2]](diffhunk://#diff-8e6e95029056db2c0301fc338e0ca5a04356ce5d45ee9514bbd167f2d85bae70L569-R569)

### New update functionality:

*
[`frontend/graph/schema.resolvers.go`](diffhunk://#diff-8e6e95029056db2c0301fc338e0ca5a04356ce5d45ee9514bbd167f2d85bae70L582-R599):
Implemented the `UpdateAction` resolver to handle updating
`AddClusterInfo` actions.
*
[`frontend/services/actions/addclusterinfo.go`](diffhunk://#diff-c2da2861415e61f772e3b44d22810aa34b4eba6070f744709c4b1b6b919a3f09L70-R137):
Added the `UpdateAddClusterInfo` function to update existing
`AddClusterInfo` actions in Kubernetes.

### Constants definition:

*
[`frontend/services/actions/constants.go`](diffhunk://#diff-377602090c56364ea3a4d6cdadda1ad9b1c6ba9e122f882e5a1f640b1e62acf8R1-R7):
Added constants for action types `ActionTypeAddClusterInfo` and
`ActionTypeDeleteAttribute`.
@BenElferink
Merge branch 'new-ui' of https://github.com/odigos-io/odigos into gen…
02682f9 
…-1511-new-ui
@BenElferink
feat(frontend): added actions form, and fixed bugs: empty inputs, sea…
522e782 
…rch bar
@alonkeyval
[GEN-1541] Add delete action mutation (odigos-io#1609)
f435deb 
This pull request introduces changes to the `DeleteAction` functionality
in the `frontend/graph` package, adding support for an `actionType`
parameter. This enhancement allows for more specific handling of
different action types during deletion.

Key changes include:

### GraphQL Schema and Resolvers

*
[`frontend/graph/schema.graphqls`](diffhunk://#diff-bc07b91dedd1782d9ddbbb6374ad97c7604f9a267de5174645723d863c732f80L314-R314):
Updated the `deleteAction` mutation to include an `actionType`
parameter.
*
[`frontend/graph/schema.resolvers.go`](diffhunk://#diff-8e6e95029056db2c0301fc338e0ca5a04356ce5d45ee9514bbd167f2d85bae70L603-R620):
Modified the `DeleteAction` resolver to handle different action types
based on the `actionType` parameter.

### Generated Code

*
[`frontend/graph/generated.go`](diffhunk://#diff-4bacf1f13939a5c243f3f83d21f4560b331d13667d81ea5945ed1f57ddb205f2L200-R200):
Updated the `DeleteAction` method signatures and complexity calculations
to include the `actionType` parameter.
[[1]](diffhunk://#diff-4bacf1f13939a5c243f3f83d21f4560b331d13667d81ea5945ed1f57ddb205f2L200-R200)
[[2]](diffhunk://#diff-4bacf1f13939a5c243f3f83d21f4560b331d13667d81ea5945ed1f57ddb205f2L266-R266)
[[3]](diffhunk://#diff-4bacf1f13939a5c243f3f83d21f4560b331d13667d81ea5945ed1f57ddb205f2L911-R911)
[[4]](diffhunk://#diff-4bacf1f13939a5c243f3f83d21f4560b331d13667d81ea5945ed1f57ddb205f2R1342-R1350)
[[5]](diffhunk://#diff-4bacf1f13939a5c243f3f83d21f4560b331d13667d81ea5945ed1f57ddb205f2L5793-R5802)

### Action Services

*
[`frontend/services/actions/addclusterinfo.go`](diffhunk://#diff-c2da2861415e61f772e3b44d22810aa34b4eba6070f744709c4b1b6b919a3f09R148-R162):
Added the `DeleteAddClusterInfo` function to handle the deletion of
`AddClusterInfo` actions.
*
[`frontend/services/actions/addclusterinfo.go`](diffhunk://#diff-c2da2861415e61f772e3b44d22810aa34b4eba6070f744709c4b1b6b919a3f09R13):
Imported `apierrors` for error handling in the new deletion function.
@alonkeyval
Lint rules (odigos-io#1610)
9dbdc21
@BenElferink
fix: KeyValueInputsList would not always call onChange
a55f35b
@BenElferink
feat: custom fields with state management
619bb6d
@BenElferink
fix: semicolon
389fc46
@BenElferink
fix: docs link
2487549
@BenElferink
fix: frament & imports
9e5224b
@BenElferink
fix: MONITORING_OPTIONS from global consts
e4a8350
@BenElferink
fix: use const, not string
a908130
@BenElferink
Merge pull request #2 from BenElferink/gen-1515-dynamic-action-form
38e862f 
PR comments
@BenElferink
fix: dynamic signals for actions
31f1db3
@BenElferink
fix: drawer & modal widths
bc3bad3
@alonkeyval
[GEN-1546] Add delete attr new api (odigos-io#1612)
f1ac07b
@alonkeyval
[GEN-1546] Add pii masking new api (odigos-io#1613)
254427a
@BenElferink
[GEN-1513]: actions modal form (odigos-io#1608)
c769731
@BenElferink
fix: stringify for graphql
89a6594
@BenElferink
Merge remote-tracking branch 'odigos/new-ui' into gen-1515-fix-string…
9d260f4 
…ify-for-graphql
@BenElferink
[GEN-1515]: fix stringify for graphql (odigos-io#1615)
19eb1fe
@BenElferink
Merge branch 'main' into new-ui
446c37a
@BenElferink
Merge pull request #4 from odigos-io/new-ui
f97a5a1 
[GEN-1515]: fix stringify for graphql (odigos-io#1615)
@alonkeyval
[GEN-1547] Add error sampler api (odigos-io#1629)
944480f
@alonkeyval
[GEN-1555] Add new latency sampler api (odigos-io#1630)
2637c1e
@alonkeyval
[GEN-1557] Add prod sampler new api (odigos-io#1631)
4cedea9 
This pull request introduces a new `ProbabilisticSamplerAction` to the
codebase, along with the necessary updates to support its creation,
update, and deletion. The key changes include adding the new action
type, updating the GraphQL schema, and implementing the corresponding
service functions.

### Addition of `ProbabilisticSamplerAction`:

*
[`frontend/graph/model/models_gen.go`](diffhunk://#diff-642ccd7ed71fdfa394bd7f7fd99c9c33e20ff18c876a91cb989d379a44390469R311-R337):
Added the `ProbabilisticSamplerAction` struct and its methods to the
model.
*
[`frontend/graph/schema.graphqls`](diffhunk://#diff-bc07b91dedd1782d9ddbbb6374ad97c7604f9a267de5174645723d863c732f80R309-R318):
Updated the GraphQL schema to include the `ProbabilisticSamplerAction`
type.

### Resolver Updates:

*
[`frontend/graph/schema.resolvers.go`](diffhunk://#diff-8e6e95029056db2c0301fc338e0ca5a04356ce5d45ee9514bbd167f2d85bae70L568-R571):
Updated the `CreateAction`, `UpdateAction`, and `DeleteAction` resolvers
to handle the new `ProbabilisticSamplerAction` type.
[[1]](diffhunk://#diff-8e6e95029056db2c0301fc338e0ca5a04356ce5d45ee9514bbd167f2d85bae70L568-R571)
[[2]](diffhunk://#diff-8e6e95029056db2c0301fc338e0ca5a04356ce5d45ee9514bbd167f2d85bae70L586-R591)
[[3]](diffhunk://#diff-8e6e95029056db2c0301fc338e0ca5a04356ce5d45ee9514bbd167f2d85bae70L617-R630)

### Constants Update:

*
[`frontend/services/actions/constants.go`](diffhunk://#diff-377602090c56364ea3a4d6cdadda1ad9b1c6ba9e122f882e5a1f640b1e62acf8L8-R9):
Added `ActionTypeProbabilisticSampler` and corrected the naming of
`ActionTypeLatencySampler`.

### Service Implementation:

*
[`frontend/services/actions/probabilisticsampler.go`](diffhunk://#diff-2f6dc14f04b67e0a11a5b999216a0e08f575927294c5033187b84f1179fb5624R1-R139):
Implemented the service functions `CreateProbabilisticSampler`,
`UpdateProbabilisticSampler`, and `DeleteProbabilisticSampler` to manage
`ProbabilisticSamplerAction` in Kubernetes.
alonkeyval and others added 26 commits November 19, 2024 09:12
@alonkeyval
Merge branch 'main' into odigos-ui-beta
4a1b6e4
@BenElferink
Merge branch 'odigos-ui-beta' of https://github.com/odigos-io/odigos
47da6bc
@alonkeyval @BenElferink
@tamirdavid1 @blumamir @RonFed @yodigos @damemi @alonbraymok
Merge current main (odigos-io#1784)
aa65e0b 
Co-authored-by: Ben Elferink <ben.elferink@icloud.com>
Co-authored-by: Tamir David <tamir@odigos.io>
Co-authored-by: Tamir David <tamirdavid@Tamirs-MacBook-Pro.local>
Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
Co-authored-by: Ron Federman <73110295+RonFed@users.noreply.github.com>
Co-authored-by: yodigos <yoav@odigos.io>
Co-authored-by: Mike Dame <mike@odigos.io>
Co-authored-by: alonbraymok <alonbraymok007@gmail.com>
@BenElferink
Merge branch 'odigos-ui-beta' of https://github.com/odigos-io/odigos
7ab5c25
@alonkeyval @BenElferink
@tamirdavid1 @blumamir @RonFed @yodigos @damemi @alonbraymok
Merge current main (odigos-io#1785)
95a3bb3 
Co-authored-by: Ben Elferink <ben.elferink@icloud.com>
Co-authored-by: Tamir David <tamir@odigos.io>
Co-authored-by: Tamir David <tamirdavid@Tamirs-MacBook-Pro.local>
Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
Co-authored-by: Ron Federman <73110295+RonFed@users.noreply.github.com>
Co-authored-by: yodigos <yoav@odigos.io>
Co-authored-by: Mike Dame <mike@odigos.io>
Co-authored-by: alonbraymok <alonbraymok007@gmail.com>
@BenElferink
Merge branch 'odigos-ui-beta' of https://github.com/odigos-io/odigos
0fc748b
@BenElferink
fix: YAML parse error
0a5b64d
@alonkeyval @BenElferink
@tamirdavid1 @blumamir @RonFed @yodigos @damemi @alonbraymok
e2e test fixes (odigos-io#1787)
c666fab 
Co-authored-by: Ben Elferink <ben.elferink@icloud.com>
Co-authored-by: Tamir David <tamir@odigos.io>
Co-authored-by: Tamir David <tamirdavid@Tamirs-MacBook-Pro.local>
Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
Co-authored-by: Ron Federman <73110295+RonFed@users.noreply.github.com>
Co-authored-by: yodigos <yoav@odigos.io>
Co-authored-by: Mike Dame <mike@odigos.io>
Co-authored-by: alonbraymok <alonbraymok007@gmail.com>
@alonkeyval @BenElferink
@tamirdavid1 @blumamir @RonFed @yodigos @damemi @alonbraymok
Merge current main (odigos-io#1788)
5250dbd 
Co-authored-by: Ben Elferink <ben.elferink@icloud.com>
Co-authored-by: Tamir David <tamir@odigos.io>
Co-authored-by: Tamir David <tamirdavid@Tamirs-MacBook-Pro.local>
Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
Co-authored-by: Ron Federman <73110295+RonFed@users.noreply.github.com>
Co-authored-by: yodigos <yoav@odigos.io>
Co-authored-by: Mike Dame <mike@odigos.io>
Co-authored-by: alonbraymok <alonbraymok007@gmail.com>
@BenElferink
fix: YAML parse error (odigos-io#1786)
68a0600
@BenElferink @alonkeyval @tamirdavid1
Fix tests timeouts (odigos-io#1789)
6fdba36 
Co-authored-by: Alon Braymok <138359965+alonkeyval@users.noreply.github.com>
Co-authored-by: Tamir David <tamir@odigos.io>
@BenElferink
Merge branch 'main' into odigos-ui-beta
a8063a1
@BenElferink
Merge branch 'main' of https://github.com/odigos-io/odigos
86c1d84
@BenElferink
Merge branch 'odigos-ui-beta' into main
8a3dc3f
@BenElferink @alonkeyval
fix tests YAML syntax (odigos-io#1790)
8d97ab5 
Co-authored-by: Alon Braymok <138359965+alonkeyval@users.noreply.github.com>
@BenElferink
fix: remove non-existant files from tests
c40fa7f
@BenElferink
Merge branch 'odigos-ui-beta' into main
cb4b96c
@BenElferink
fix: remove again
e32f7d9
@BenElferink
Merge branch 'main' of https://github.com/odigos-io/odigos
3fdab6c
@BenElferink
Merge branch 'main' of https://github.com/odigos-io/odigos
155a1a5
@BenElferink
Merge branch 'main' of https://github.com/odigos-io/odigos
dbd5690
@BenElferink
Merge branch 'main' of https://github.com/odigos-io/odigos
0c68c8c
@BenElferink
Merge branch 'main' of https://github.com/odigos-io/odigos
ed87a46
@BenElferink
Merge branch 'main' of https://github.com/odigos-io/odigos
a5de5e9
@BenElferink
Merge branch 'main' of https://github.com/odigos-io/odigos
def460c
@BenElferink
fix: state of "recordedRows" in "monitors" checkbox list
7a64bd9
@notion-workspace Notion Workspace
Copy link

actions modal - the "monitors" reset between renders (they should be selected by default)

@BenElferink BenElferink merged commit 195e50a into odigos-io:ui-bugs-party Nov 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alonkeyval alonkeyval alonkeyval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenElferink @alonkeyval