-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEN-1910]: init workflow for UI E2E tests (using Cypress) #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenElferink
requested review from
blumamir,
tamirdavid1 and
alonkeyval
and removed request for
blumamir and
tamirdavid1
December 4, 2024 15:58
This workflow has been tested:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to enhance end-to-end (E2E) testing and Cypress integration, along with some minor adjustments to configuration files. The most important changes focus on adding new test scenarios, updating Cypress configurations, and introducing new scripts for managing the UI.
Enhancements to E2E Testing:
.github/workflows/e2e.yaml
: Added 'ui' to thetest-scenario
matrix and removed the installation step for the frontend, which was only used for specific scenarios. [1] [2]tests/e2e/ui/chainsaw-test.yaml
: Introduced a new test configuration to run E2E tests against the Odigos UI using Cypress.Cypress Integration:
frontend/webapp/cypress.config.ts
: Updated the Cypress configuration to useCypress.defineConfig
and added additional settings likesupportFile
andwaitForAnimations
.frontend/webapp/package.json
: Added new scripts for opening and running Cypress tests (cy:open
andcy:run
) and updated the Cypress version. [1] [2]frontend/webapp/cypress/e2e/spec.cy.ts
: Added a new Cypress test for the onboarding process, ensuring that a fresh install redirects to the onboarding start.Additional Changes:
frontend/webapp/cypress/.gitignore
: Added a rule to ignore Cypress screenshots.tests/common/odigos_ui.sh
: Added a new script to manage the Odigos UI, including functions to start, stop, and test the UI, with proper error handling and process management.tests/common/.gitignore
: Added rules to ignore.pid
and.log
files.tests/e2e/cli-upgrade/odigos-ui.pid
: Removed a hardcoded process ID.