-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEN-2004] feat(frontend): source describe #1977
Merged
BenElferink
merged 233 commits into
odigos-io:main
from
alonkeyval:gen-2004-source-describe-gql
Dec 12, 2024
Merged
[GEN-2004] feat(frontend): source describe #1977
BenElferink
merged 233 commits into
odigos-io:main
from
alonkeyval:gen-2004-source-describe-gql
Dec 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntainer Task 149 sources container
…play-source-manage-list
…urces-card Task 107 overview sources card
…rce-manage-list Task 142 display source manage list
…rce-btn Task 143 add new source btn
…sources-connection Task 145 handle new sources connection
alonkeyval
changed the title
[Gen-2004] feat(frontend): source describe
[GEN-2004] feat(frontend): source describe
Dec 12, 2024
BenElferink
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several new types and functionalities to enhance the analysis and description of Kubernetes sources in the
frontend/graph
module. The key changes include the addition of new types in the GraphQL schema and the implementation of a resolver function to describe sources.New Types and Schema Enhancements:
frontend/graph/schema.graphqls
):EntityProperty
,InstrumentationLabelsAnalyze
,InstrumentationConfigAnalyze
,ContainerRuntimeInfoAnalyze
,RuntimeInfoAnalyze
,InstrumentedApplicationAnalyze
,ContainerWorkloadManifestAnalyze
,InstrumentationDeviceAnalyze
,InstrumentationInstanceAnalyze
,PodContainerAnalyze
,PodAnalyze
, andSourceAnalyze
.describeSource
query and adjusted formatting for better readability. (frontend/graph/schema.graphqlsL208-R212, Fdc622fbL474R541)New Structs and Types:
frontend/graph/model/models_gen.go
):ContainerRuntimeInfoAnalyze
,ContainerWorkloadManifestAnalyze
,EntityProperty
,InstrumentationConfigAnalyze
,InstrumentationDeviceAnalyze
,InstrumentationInstanceAnalyze
,InstrumentationLabelsAnalyze
,InstrumentedApplicationAnalyze
,PodAnalyze
,PodContainerAnalyze
,RuntimeInfoAnalyze
, andSourceAnalyze
. [1] [2] [3] [4] [5] [6] [7]Resolver Implementation:
frontend/graph/schema.resolvers.go
):DescribeSource
resolver function to handle the newdescribeSource
query.Service Layer:
frontend/services/describe.go
):GetSourceDescription
to fetch and convert source descriptions from Kubernetes into GraphQL response format.These changes collectively enhance the system's ability to analyze and describe Kubernetes sources, providing detailed insights into various properties and configurations.