Use GOMAXPROCS in gateway based on limits.cpu #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blumamir
approved these changes
Dec 15, 2024
Comment on lines
106
to
109
| - name: Odigos pipeline ready | ||
| try: | ||
| - assert: | ||
| file: ../../common/assert/pipeline-ready.yaml |
There was a problem hiding this comment.
This guaranteed that we do not progress until the pipeline is ready.
Wonder if removing the assert can cause issues
There was a problem hiding this comment.
I added this step back, but only to make sure all the pods are ready, not asserting all the pods spec.
The full pipeline ready assert will be after the upgrade as before
blumamir
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant references on why this is important:
https://www.ardanlabs.com/blog/2024/02/kubernetes-cpu-limits-go.html
https://engineering.grab.com/performance-bottlenecks-go-apps