[GEN-1840]: refactor frontend icons from SVG to JSX #2017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…proved flexibility
…ges across the application
…ctionality into MainHeader
alonkeyval
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
frontend/webappdirectory, primarily focusing on refactoring SVG icons to React components and updating the icon exports. The most important changes include renaming and converting SVG files to React components, updating the global CSS, and modifying the layout file.Icon Refactoring:
frontend/webapp/assets/icons/actions/add-cluster-info-icon.tsx: Renamed fromaddclusterinfo.svgand converted to a React component.frontend/webapp/assets/icons/actions/delete-attribute-icon.tsx: Renamed fromdeleteattribute.svgand converted to a React component.frontend/webapp/assets/icons/actions/pii-masking-icon.tsx: Renamed frompiimasking.svgand converted to a React component.frontend/webapp/assets/icons/actions/sampler-icon.tsx: Renamed fromsampler.svgand converted to a React component.frontend/webapp/assets/icons/actions/rename-attribute-icon.tsx: Added as a new React component.Icon Export Updates:
frontend/webapp/assets/icons/actions/index.ts: Added exports for the newly converted React components.Brand Icons:
frontend/webapp/assets/icons/brand/odigos-logo-background.tsx: Added as a new React component.frontend/webapp/assets/icons/brand/odigos-logo-text.tsx: Added as a new React component.frontend/webapp/assets/icons/brand/odigos-logo.tsx: Added as a new React component.frontend/webapp/assets/icons/brand/index.ts: Added exports for the new brand icons.Common Icons:
frontend/webapp/assets/icons/common/arrow-icon.tsx: Added as a new React component.Miscellaneous:
frontend/webapp/app/globals.css: Added a transition effect tosvgelements.frontend/webapp/app/layout.tsx: Removed the SVG icon link from the metadata.