Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEN-2057]: make onClick optional for Tab component and adjust styling #2030

Merged
merged 11 commits into from
Dec 19, 2024

Conversation

BenElferink
Copy link
Contributor

This pull request includes several changes to the frontend/webapp/reuseable-components/tab-list/index.tsx file to enhance the TabList component's flexibility and behavior. The most important changes include making the onClick property optional, adding a new $noClick property to the TabContainer styled component, and modifying the TabList component export.

Enhancements to TabList component:

  • Made the onClick property optional in the TabProps interface.
  • Added a new $noClick property to the TabContainer styled component to handle cases where onClick is not provided. [1] [2]
  • Removed the onClick property from the Overview tab in the TABS array.

Codebase adjustments:

  • Changed the TabList component to be exported directly instead of using a separate export statement. [1] [2]

Copy link

@BenElferink BenElferink enabled auto-merge (squash) December 19, 2024 15:36
@BenElferink BenElferink merged commit c22b7cd into odigos-io:main Dec 19, 2024
31 checks passed
@BenElferink BenElferink deleted the gen-2057 branch January 6, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants