-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source CRD & Instru. Config handling in UI Backend #2092
Merged
BenElferink
merged 173 commits into
odigos-io:feature/source-crd
from
BenElferink:feature/source-ui
Dec 30, 2024
Merged
Source CRD & Instru. Config handling in UI Backend #2092
BenElferink
merged 173 commits into
odigos-io:feature/source-crd
from
BenElferink:feature/source-ui
Dec 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create & Delete Source CRD via UI
…ing in instrumentation watcher
…nd instance watchers
…le CRUD operations
…o feature/source-ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
This pull request includes various changes across multiple files, focusing on updating configurations, refining comments, and enhancing functionality. The most important changes include updating Go version formatting in the build workflow, adding new annotations and constants, and refining permissions and roles in the resource files.
Configuration Updates:
.github/workflows/build.yaml
: Updated the Go version formatting from double quotes to single quotes in multiple job steps. [1] [2] [3] [4] [5]Constants and Annotations:
common/consts/consts.go
: Added new annotations for workload namespace, kind, and name, as well as constants for CRD types. [1] [2]Permissions and Roles:
cli/cmd/resources/README.md
: Updated the permissions table for various components, including adding new verbs and resources for the UI component. [1] [2] [3]cli/cmd/resources/ui.go
: Refined comments and resource definitions for roles, including CRUD operations and watch permissions for Odigos entities. [1] [2] [3] [4]Code Refinements:
frontend/endpoints/sse/sse.go
: Added new message types and events for SSE messages.frontend/graph/conversions.go
: Modified function to map instrumentation configurations to actual sources, including container runtime details. [1] [2]frontend/graph/model/models_gen.go
: UpdatedComputePlatform
struct to include new fields for actual sources and namespaces.Minor Changes:
Makefile
: Added--nowait
flag to thecli-install
target.autoscaler/controllers/gateway/configmap.go
: Corrected a capitalization error in a log message.These changes collectively improve the build process, enhance code readability, and ensure proper configuration and permissions management across the project.