[GEN-2140]: improve UX for "pending" states #2106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create & Delete Source CRD via UI
…ntation rule hooks
…nation and source CRUD operations
…nce node handling
…useSourceCRUD hooks
…nd usePendingStore
…pending items logic in useSSE and usePendingStore
alonkeyval
approved these changes
Dec 31, 2024
damemi
reviewed
Dec 31, 2024
frontend/webapp/containers/main/overview/overview-data-flow/build-destination-nodes.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes multiple changes to improve the handling of pending states and notifications in the frontend web application. The most important changes include the addition of pending state management, updates to notification handling, and minor UI improvements.
Pending State Management:
frontend/webapp/hooks/destinations/useDestinationCRUD.ts: AddedaddPendingItemscalls to manage pending states for create, update, and delete destination actions.frontend/webapp/hooks/sources/useSourceCRUD.ts: AddedaddPendingItemscalls to manage pending states for persisting and updating sources.Notification Handling:
frontend/webapp/hooks/actions/useActionCRUD.ts: Updated to includeremoveNotificationsin the notification store.frontend/webapp/hooks/notification/useSSE.ts: AddedsetPendingItemsto clear pending states upon successful SSE connection.UI Improvements:
frontend/webapp/containers/main/overview/overview-data-flow/build-destination-nodes.ts: Fixed a typo in the node title from 'ADD DESTIONATION' to 'ADD DESTINATION'.frontend/webapp/containers/main/overview/overview-drawer/index.tsx: AddeduseMemofor pending state checks and integrated notification handling for pending actions like edit and delete. [1] [2]These changes enhance the application's user experience by providing better feedback and handling for pending operations and notifications.