[GEN-2199] UI types linter #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntainer Task 149 sources container
…play-source-manage-list
…urces-card Task 107 overview sources card
…rce-manage-list Task 142 display source manage list
…rce-btn Task 143 add new source btn
…sources-connection Task 145 handle new sources connection
BenElferink
approved these changes
Jan 8, 2025
|
|
||
| type Item = InstrumentationRuleSpec | K8sActualSource | ActionDataParsed | ActualDestination; | ||
|
|
||
| export const getEntityItemId = (item: Item): string | { kind: string; name: string; namespace: string } | undefined => { |
There was a problem hiding this comment.
Suggested change
| export const getEntityItemId = (item: Item): string | { kind: string; name: string; namespace: string } | undefined => { | |
| export const getEntityItemId = (item: Item): string | WorkloadId | undefined => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve type safety and code clarity in the
frontend/webappdirectory. The most important changes include adding type annotations, refactoring object construction, and updating TypeScript configuration for stricter type checking.Improvements to type safety:
frontend/webapp/components/notification/toast-list.tsx: Added type annotations to theonClosefunction parameter to ensure it is an object with a booleanasSeenproperty.frontend/webapp/containers/main/destinations/destination-drawer/build-card.ts: Updated thefiltermethod to use a type-safe key lookup onExportedSignals.frontend/webapp/containers/main/destinations/destination-modal/choose-destination-body/destinations-list/index.tsx: Added type annotations forSupportedSignalsin themonitorsfilter method.Code clarity improvements:
frontend/webapp/containers/main/destinations/destination-drawer/build-drawer-item.ts: Refactored the construction offieldsStringifiedby first building an object and then converting it to a JSON string.TypeScript configuration update:
frontend/webapp/tsconfig.json: Enabled thenoImplicitAnycompiler option to enforce explicit type annotations, improving overall type safety.