Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create effective-config configmap #2176

Merged
merged 5 commits into from
Jan 10, 2025

Conversation

blumamir
Copy link
Collaborator

The "odigos-config" configmap in odigos is currently treated as "user" object, containing raw configuration as the user supplied it.

It can come from few places:

  • cli (via install)
  • manual edits of the cm
  • gitops (forcing the content)
  • ui (not at the moment, but in the future)

This PR introduces a new "effective-config" configmap that is reconciled in schedualer. Having a reconciliation step will allow us to:

  • consolidate duplicate code in cli and helm that does defaulting, maintaining the default values and merging in one place and update regardless of the source of these values
  • ability to apply profiles as odigos-config changes
  • removing any config handling specific logic from consumers (like defaulting, applying profiles, merging different options), o they will get the digested values ready to use
  • good visibility into the reconciled values that effectively used by various odigos components after they are processed

@blumamir blumamir changed the title feat: create effective-config cm feat: create effective-config configmap Jan 10, 2025
@blumamir blumamir merged commit 899906b into odigos-io:main Jan 10, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants