[IMP] model: create snapshot when loading xlsx file #5320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
14 tasks
src/model.ts
Outdated
| @@ -281,7 +281,7 @@ export class Model extends EventBus<any> implements CommandDispatcher { | |||
|
|
|||
| this.joinSession(); | |||
|
|
|||
| if (config.snapshotRequested) { | |||
| if (config.snapshotRequested || data["[Content_Types].xml"]) { | |||
There was a problem hiding this comment.
it should not snapshot if the spreadsheet is in read-only mode (because the user most cannot update the spreadsheet in any way)
Rachico
force-pushed
the
18.0-snapshot-when-open-xlsx-mera
branch
2 times, most recently
from
d4ac9cd to
1bbd91a
Compare
pro-odoo
requested changes
Dec 20, 2024
tests/model/model.test.ts
Outdated
| @@ -366,4 +369,22 @@ describe("Model", () => { | |||
| ], | |||
| }); | |||
| }); | |||
|
|
|||
| test("snapshot when importing xlsx file", async () => { | |||
| jest.spyOn(console, "warn").mockImplementation(() => {}); | |||
There was a problem hiding this comment.
there is a global handler to make the tests fail in case of console.error or console.warn
There was a problem hiding this comment.
I know this global handler, but if I comment this line, the test does not fail. Expected ?
There was a problem hiding this comment.
That's weird, it was failing before 🤷
| if (config.snapshotRequested) { | ||
| if ( | ||
| config.snapshotRequested || | ||
| (data["[Content_Types].xml"] && this.config.mode !== "readonly") |
There was a problem hiding this comment.
Add a test for the readonly flag
Rachico
force-pushed
the
18.0-snapshot-when-open-xlsx-mera
branch
from
1bbd91a to
4804a36
Compare
Before this commit, when uploading an XLSX file, the code in the Odoo repository would create a spreadsheet document with data that is encoded in xml. Whenever the file is loaded, we parse the stringified xml to convert it to the o-spreadsheet json structure. The problem is that this conversion can be quite slow and costly when the XLSX file is large. This commit mitigates the issue by saving a snapshot once the XLSX file is loaded for the first time. Task: 4080514
Rachico
force-pushed
the
18.0-snapshot-when-open-xlsx-mera
branch
from
4804a36 to
adb4f86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, when uploading an XLSX file, the code in the Odoo repository would create a spreadsheet document with data that is encoded in xml. Whenever the file is loaded, we parse the stringified xml to convert it to the o-spreadsheet json structure. The problem is that this conversion can be quite slow and costly when the XLSX file is large.
This commit mitigates the issue by saving a snapshot once the XLSX file is loaded for the first time.
Task: 4080514
review checklist