Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] pivot: ensure correct format status in menu #5339

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from

Conversation

dhrp-odoo
Copy link
Contributor

Description:

Since PR #4657, users can define a custom format for pivot measures by selecting a cell with a measure value and applying a format.

However, the format menu's tick status incorrectly displayed "Automatic" even after applying a custom format. This was caused by the getCell method fetching the cell format, which does not account for pivot measure-specific formats.

This fix ensures the format menu reflects the correct status by properly handling pivot cell measure formats.

Task: 4373606

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Dec 11, 2024

Pull request status dashboard

Since PR#4657, users can define a custom format for pivot measures by
selecting a cell with a measure value and applying a format.

However, the format menu's tick status incorrectly displayed "Automatic"
even after applying a custom format. This was caused by the getCell
method fetching the cell format, which does not account for pivot
measure-specific formats.

This fix ensures the format menu reflects the correct status by
properly handling pivot cell measure formats.

Task: 4373606
@dhrp-odoo dhrp-odoo force-pushed the 18.0-fix-odoo-pivot-format-dhrp branch from 07fdc17 to 26372eb Compare December 13, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants