Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] spreadsheet: avoid parasitic renders #5346

Open
wants to merge 1 commit into
base: saas-17.2
Choose a base branch
from
Open

[FIX] spreadsheet: avoid parasitic renders #5346

wants to merge 1 commit into from

Conversation

hokolomopo
Copy link
Contributor

Description

Clicking on a button on the topbar would trigger 3 renders:

  • one on model update (expected)
  • one because we received a collaborative event for our own revision (useless)
  • one because the onClick of the topbar calls DOMFocusableElementStore.focus, which triggers a render because a store method was called (useless)

Task: 4373054

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@hokolomopo
[FIX] spreadsheet: avoid parasitic renders
4cc3ea8 
Clicking on a button on the topbar would trigger 3 renders:
- one on model update (expected)
- one because we received a collaborative event for our own revision
(useless)
- one because the onClick of the topbar calls
`DOMFocusableElementStore.focus`, which triggers a render because a
store method was called (useless)

Task: 4373054
@robodoo
Copy link
Collaborator

robodoo commented Dec 13, 2024

Pull request status dashboard

rrahir
rrahir reviewed Dec 23, 2024
View reviewed changes
src/stores/DOM_focus_store.ts
mutators = ["setFocusableElement", "focus"] as const;
private focusableElement: HTMLElement | undefined = undefined;
mutators = ["setFocusableElement"] as const;
focusableElement: HTMLElement | undefined = undefined;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we're up doing this kind of things, I'd rather have the possibility to mark a mutator as "not recomputing anything and therefore don't need to render"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrahir rrahir rrahir left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hokolomopo @robodoo @rrahir