-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
16.0 runbot docker registry moc #799
Open
d-fence
wants to merge
12
commits into
17.0
Choose a base branch
from
16.0-runbot-docker-registry-moc
base: 17.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xavier-Do
force-pushed
the
16.0-runbot-docker-registry-moc
branch
from
July 26, 2024 12:59
105e855
to
2f97c68
Compare
d-fence
force-pushed
the
16.0-runbot-docker-registry-moc
branch
from
August 9, 2024 12:15
2f97c68
to
3dd24d2
Compare
When building a docker image the error is part of the stream, and at the end. The current behaviour will append the error message at the begining of the "result log" breaking the temporality of the output. Adding it at the end should be more intuitive to read. This will also help to get a more usefull error sumary in some cases.
Xavier-Do
force-pushed
the
16.0-runbot-docker-registry-moc
branch
6 times, most recently
from
August 12, 2024 13:05
c9756a2
to
9c60f5b
Compare
If the host is the docker registry used globally, it should build the docker image. Otherwise, if the host is not using a registry to pull the images, it should build them locally. In either cases, it should push the local images to the local registry as each runbot builder is hosting a Docker registry.
Xavier-Do
force-pushed
the
16.0-runbot-docker-registry-moc
branch
5 times, most recently
from
August 12, 2024 13:43
bcb3cd7
to
e898ef5
Compare
Xavier-Do
force-pushed
the
16.0-runbot-docker-registry-moc
branch
from
August 13, 2024 07:59
e898ef5
to
93a01a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually, when using multiple runbot builders each one is building its Docker images.
Although they use the same Dockerfile, some small differences could happen.
e.g., two runbot host are not setup at the same date some distribution packages may have been updated in the most recent Docker built image.
This PR adds the possibility to use a Docker registry. By default, the runbot should work without a registry and each host can be configured to use it or not.
THIS PR IS A DRAFT TEST