Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16.0 runbot docker registry moc #799

Open
wants to merge 12 commits into
base: 17.0
Choose a base branch
from

Conversation

d-fence
Copy link
Contributor

@d-fence d-fence commented Jul 20, 2023

Actually, when using multiple runbot builders each one is building its Docker images.
Although they use the same Dockerfile, some small differences could happen.

e.g., two runbot host are not setup at the same date some distribution packages may have been updated in the most recent Docker built image.

This PR adds the possibility to use a Docker registry. By default, the runbot should work without a registry and each host can be configured to use it or not.

THIS PR IS A DRAFT TEST

@d-fence d-fence requested a review from Xavier-Do July 20, 2023 09:18
@Xavier-Do Xavier-Do marked this pull request as ready for review July 25, 2024 06:07
@C3POdoo C3POdoo requested a review from a team July 25, 2024 06:09
@Xavier-Do Xavier-Do force-pushed the 16.0-runbot-docker-registry-moc branch from 105e855 to 2f97c68 Compare July 26, 2024 12:59
@Xavier-Do Xavier-Do changed the base branch from 16.0 to 17.0 July 26, 2024 13:00
@d-fence d-fence force-pushed the 16.0-runbot-docker-registry-moc branch from 2f97c68 to 3dd24d2 Compare August 9, 2024 12:15
When building a docker image the error is part of the stream, and
at the end.

The current behaviour will append the error message at the begining of
the "result log" breaking the temporality of the output. Adding it at
the end should be more intuitive to read. This will also help to get a
more  usefull error sumary in some cases.
@Xavier-Do Xavier-Do force-pushed the 16.0-runbot-docker-registry-moc branch 6 times, most recently from c9756a2 to 9c60f5b Compare August 12, 2024 13:05
If the host is the docker registry used globally, it should build the
docker image. Otherwise, if the host is not using a registry to pull the
images, it should build them locally.

In either cases, it should push the local images to the local registry
as each runbot builder is hosting a Docker registry.
@Xavier-Do Xavier-Do force-pushed the 16.0-runbot-docker-registry-moc branch 5 times, most recently from bcb3cd7 to e898ef5 Compare August 12, 2024 13:43
@Xavier-Do Xavier-Do force-pushed the 16.0-runbot-docker-registry-moc branch from e898ef5 to 93a01a6 Compare August 13, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants