[IMP] Add per-channel encryption feature #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThanhDodeurOdoo
force-pushed
the
master-sfu-sh-compat-tso
branch
from
64adef0 to
cf2ab45
Compare
ThanhDodeurOdoo
force-pushed
the
master-sfu-sh-compat-tso
branch
from
cf2ab45 to
4e0320f
Compare
ThanhDodeurOdoo
force-pushed
the
master-sfu-sh-compat-tso
branch
from
4e0320f to
a2c7d95
Compare
This was referenced Apr 12, 2024
ThanhDodeurOdoo
force-pushed
the
master-sfu-sh-compat-tso
branch
2 times, most recently
from
1fa9363 to
8a4d3ca
Compare
ThanhDodeurOdoo
force-pushed
the
master-sfu-sh-compat-tso
branch
from
8a4d3ca to
0a409a2
Compare
ThanhDodeurOdoo
force-pushed
the
master-sfu-sh-compat-tso
branch
from
0a409a2 to
cc7c640
Compare
ThanhDodeurOdoo
force-pushed
the
master-sfu-sh-compat-tso
branch
from
cc7c640 to
d1bd746
Compare
ThanhDodeurOdoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 25, 2024
This commit adds support for the per-channel encryption SFU feature introduced in: odoo/sfu#7 This change is useful for cases like Odoo.SH where multiple parties can use the same SFU with the same credentials. task-3861455
ThanhDodeurOdoo
force-pushed
the
master-sfu-sh-compat-tso
branch
4 times, most recently
from
0fd229e to
d220d3c
Compare
alexkuhn
reviewed
May 7, 2024
This commit adds per-channel encryption to prevent users from signing JWTs for channels that they did not create. This features works by allowing an additional `key` claim in the JWT used to request a room. When this claim is set, the JWTs used to authenticate users are expected to be signed by this new key and not the "global" SFU key (`AUTH_KEY` global variable). This change is useful for cases like Odoo.SH where multiple parties can use the same SFU with the same credentials. task-3861455
ThanhDodeurOdoo
force-pushed
the
master-sfu-sh-compat-tso
branch
from
d220d3c to
9607bdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds per-channel encryption to prevent users from signing JWTs for channels that they did not create.
This change is useful for cases like Odoo.SH where multiple parties can use the same SFU with the same credentials.
task-3861455