-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate why Polymer build needs 3GB to run (node, windows, workaround in place) #2388
Comments
Raised whilst debugging #2350 |
When the 'Polymer build' execution occurs I see 'node' consuming lots of memory before crashing. So for example one can include this in the maven exec plugin definition for Polymer build (within the configuration tag)
When this is done node happily takes more memory (default is 512) - in fact by observing it appears this step of the process requires 3GB of memory, even with the latest versions of node/NPM This is not a effective build process, but it's worth including the parm for now as a) it's just a max and b) It always fails on windows leaving egeria unbuildable. I will raise as a PR I will then leave this open and update the title so that we can come back and try and figure out WHY > 3GB is needed on windows where the default seems ok on macOS. Note the PR bumps versions as per #1108 which has not attracted further discussion but does represent a security issue as well as being one of the recommendations found when researching this issue |
With the change in place a WIndows build succeeds, and the UI launches correctly, |
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
#2388 increase node heap to fix Windows UI build failure OOM
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions. |
Since this relates to build reliability will keep it open to investigate |
still need investigation |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions. |
ui has now been moved out and defaults working ok so closing |
Building on windows 10 (very current) with adoptopenjdk 11 openj9 the polymer build fails with:
A google search suggests this isn't uncommon... and may need changes to the build scripts.
As an aside: Seeing a few platform specific issues - may be worth extending our automated builds to include windows. OR to explicitly state we are not supporting/working with. Or somewhat inbetween, only support WSL2 See #1307
The text was updated successfully, but these errors were encountered: