Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Duplicate/clashing ports used in FVT #6450

Closed
1 task done
planetf1 opened this issue Apr 27, 2022 · 3 comments · Fixed by #6451
Closed
1 task done

[BUG] Duplicate/clashing ports used in FVT #6450

planetf1 opened this issue Apr 27, 2022 · 3 comments · Fixed by #6451
Assignees
Labels
bug Something isn't working triage New bug/issue which needs checking & assigning

Comments

@planetf1
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Some FVTs are failing.

One possible cause is that the same ports are used for different tests. This only affects gradle by default, since tests are run in parallel.

Expected Behavior

No duplicate ports should be used

Steps To Reproduce

See https://github.com/odpi/egeria/actions/runs/2232481822
and https://github.com/odpi/egeria/actions/runs/2227325114

This may not be the cause of those failures, but it is a latent problem noticed during inspection and should be fixed

Environment

- Egeria:
- OS:
- Java:
- Browser (for UI issues):
- Additional connectors and integration:

Any Further Information?

No response

@planetf1 planetf1 added bug Something isn't working triage New bug/issue which needs checking & assigning labels Apr 27, 2022
@planetf1 planetf1 self-assigned this Apr 27, 2022
@planetf1
Copy link
Member Author

Dups are in

  • 10446 - community profile & data manager

Fixing

@planetf1
Copy link
Member Author

There are far more clashes in the poms -- many are using 10446.

Will fix those too...

planetf1 added a commit to planetf1/egeria that referenced this issue Apr 27, 2022
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
This was referenced Apr 27, 2022
@planetf1
Copy link
Member Author

planetf1 commented Apr 27, 2022

I found quite a few discrepancies - I wonder how the gradle FVTs ever worked (the initial set were fine, the issue arose as more tests were added) as some of the modules recently added were all over the place including discovery & community. This could quite easily lead to a server 'going away' whilst a test was running (since that other test has finished) or possibly assets not being found in an expected state due to other concurrent activity. The intent of the tests was always to keep the isolation between them.

For now I've ensured they are all consistent and unique, and added a top level README with the current allocations.

Can't be sure this is the cause of intermittent failures, but it's quite possible, and needed fixing anyway

Some refactoring (already done in glossary author & data engine) could help clarify- at least reducing duplication within a module, but even better would be to

  • Dynamically figure out a free port to use
  • Prevent overlapping (could be a gradle constraint easily)

however I've not done further refactoring at this point

planetf1 added a commit that referenced this issue Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage New bug/issue which needs checking & assigning
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant