Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Ensure gradle runs all JUnit4/5 tests #6515

Closed
1 task done
planetf1 opened this issue May 3, 2022 · 1 comment · Fixed by #6516
Closed
1 task done

[BUG] Ensure gradle runs all JUnit4/5 tests #6515

planetf1 opened this issue May 3, 2022 · 1 comment · Fixed by #6516
Assignees
@planetf1
Labels
bug Something isn't working triage New bug/issue which needs checking & assigning

Comments

@planetf1
Copy link
Member

planetf1 commented May 3, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Many tests are not getting run by the gradle build

Expected Behavior

Gradle build should run the same tests as maven

Steps To Reproduce

No response

Environment

- Egeria:
- OS:
- Java:
- Browser (for UI issues):
- Additional connectors and integration:

Any Further Information?

Whilst debugging #6494 I noticed that the gradle update had worked, but the maven one had it. On investigation it seems as if the open lineage tests were not running.

Gradle needs to be updated to ensure all JUnit4 and Junit5 tests are run
@planetf1 planetf1 added bug Something isn't working triage New bug/issue which needs checking & assigning labels May 3, 2022
@planetf1 planetf1 self-assigned this May 3, 2022
@planetf1
Copy link
Member Author

planetf1 commented May 3, 2022

With the test update, openlineage testing now fails - consistently with maven, requiring a back off of the dependency update
that caused the maven failure.

planetf1 added a commit to planetf1/egeria that referenced this issue May 3, 2022
@planetf1
odpi#6515 ensure gradle runs all junit4/5 tests
1fa0f19 
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
@planetf1 planetf1 changed the title [BUG] <title> [BUG] Ensure gradle runs all JUnit4/5 tests May 3, 2022
@planetf1 planetf1 mentioned this issue May 3, 2022
Merged
planetf1 added a commit to planetf1/egeria that referenced this issue May 3, 2022
@planetf1
odpi#6515 ensure OpenLineageGraphValidationTests disabled (as in pom)…
f95be35 
… for gradle

Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
planetf1 added a commit that referenced this issue May 3, 2022
@planetf1
Merge pull request #6516 from planetf1/gradletest
fd72cc9 
#6515 ensure gradle runs all junit4/5 tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@planetf1 planetf1

Labels
bug Something isn't working triage New bug/issue which needs checking & assigning
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#6515 ensure gradle runs all junit4/5 tests planetf1/egeria
1 participant
@planetf1