Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add storage of entity proxy along with the classification operation #6039

Merged
merged 26 commits into from
Jan 25, 2022
Merged

Add storage of entity proxy along with the classification operation #6039

merged 26 commits into from
Jan 25, 2022

Conversation

lcpopa
Copy link
Contributor

@lcpopa lcpopa commented Dec 16, 2021 •
edited
Loading

Signed-off-by: Liviu Popa liviu-constantin.popa@ing.com

Description

Use case:

  • ols requests latest changes from al-omas which interogates igc via igc-proxy
  • igc-proxy returns latest changes to al-omas which builds the context for returned entities
  • classifying fails on returned entities because they do not exist in local repo
  • added ability to save their proxies when classifying them

PR does not contain event processing changes for classify actions.

Fixes #5836

How Has This Been Tested?

Automatic and manual on described use case. Succesfuly executed jupyter lab "Building a Data Catalog"

Any additional notes for reviewers?

@lcpopa
Add storage of entity proxy along with the classification operation
d2abac3 
Signed-off-by: Liviu Popa <liviu-constantin.popa@ing.com>
@lcpopa lcpopa marked this pull request as draft December 16, 2021 10:01
lcpopa added 14 commits December 16, 2021 12:22
@lcpopa
Merge branch 'master' of https://github.com/odpi/egeria
ed83e2c
@lcpopa
Add storage of entity proxy along with the classification operation
3f8d5f9 
Signed-off-by: Liviu Popa <liviu-constantin.popa@ing.com>
@lcpopa
Merge branch 'master' of https://github.com/odpi/egeria
e62c82e
@lcpopa
Add storage of entity proxy along with the classification operation
c870ddd 
Signed-off-by: Liviu Popa <liviu-constantin.popa@ing.com>
@lcpopa
Add storage of entity proxy along with the classification operation
3c3d1af 
Signed-off-by: Liviu Popa <liviu-constantin.popa@ing.com>
@lcpopa
Merge branch 'master' of https://github.com/odpi/egeria
292e58b
@lcpopa
Merge branch 'master' of https://github.com/odpi/egeria
e81e54d
@lcpopa
Merge branch 'master' of https://github.com/odpi/egeria
d612218
@lcpopa
Add storage of entity proxy along with the classification operation
1335a46 
Signed-off-by: Liviu Popa <liviu-constantin.popa@ing.com>
@lcpopa
Add storage of entity proxy along with the classification operation
f1405c5 
Signed-off-by: Liviu Popa <liviu-constantin.popa@ing.com>
@lcpopa
Merge branch 'master' of https://github.com/odpi/egeria
204196d
@lcpopa
Merge branch 'master' of https://github.com/odpi/egeria
e54477c
@lcpopa
Merge branch 'master' of https://github.com/odpi/egeria
68241dc
@lcpopa
Merge branch 'master' of https://github.com/odpi/egeria
c21b982
mandy-chessell
mandy-chessell previously requested changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@mandy-chessell mandy-chessell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great - comments only on updating the code formatting to match the rest of OMRS.

...ters/repositoryservices/graphrepository/repositoryconnector/GraphOMRSMetadataCollection.java Outdated Show resolved Hide resolved
...adapters/repositoryservices/inmemory/repositoryconnector/InMemoryOMRSMetadataCollection.java Outdated Show resolved Hide resolved
...adapters/repositoryservices/inmemory/repositoryconnector/InMemoryOMRSMetadataCollection.java Outdated Show resolved Hide resolved
...adapters/repositoryservices/inmemory/repositoryconnector/InMemoryOMRSMetadataCollection.java Outdated Show resolved Hide resolved
...adapters/repositoryservices/inmemory/repositoryconnector/InMemoryOMRSMetadataCollection.java Outdated Show resolved Hide resolved
...repositoryservices/localrepository/repositorycontentmanager/OMRSRepositoryContentHelper.java Outdated Show resolved Hide resolved
...repositoryservices/localrepository/repositorycontentmanager/OMRSRepositoryContentHelper.java Outdated Show resolved Hide resolved
...repositoryservices/localrepository/repositorycontentmanager/OMRSRepositoryContentHelper.java Outdated Show resolved Hide resolved
...repositoryservices/localrepository/repositorycontentmanager/OMRSRepositoryContentHelper.java Outdated Show resolved Hide resolved
...repositoryservices/localrepository/repositorycontentmanager/OMRSRepositoryContentHelper.java Outdated Show resolved Hide resolved
lcpopa and others added 5 commits January 19, 2022 09:35
@lcpopa
Merge branch 'master' of https://github.com/odpi/egeria
2f170ca
@planetf1
Merge branch 'master' into master
486959f
@lcpopa
Merge branch 'master' of https://github.com/odpi/egeria
8284896 
� Conflicts:
�	open-metadata-implementation/adapters/open-connectors/repository-services-connectors/open-metadata-collection-store-connectors/graph-repository-connector/src/main/java/org/odpi/openmetadata/adapters/repositoryservices/graphrepository/repositoryconnector/GraphOMRSMetadataStore.java
@lcpopa
Fix conflicts
9c22a06 
Signed-off-by: Liviu Popa <liviu-constantin.popa@ing.com>
@lcpopa
Fix indentation
32c0f54 
Signed-off-by: Liviu Popa <liviu-constantin.popa@ing.com>
lcpopa added 4 commits January 19, 2022 14:17
@lcpopa
Fix conflict
6973200 
Signed-off-by: Liviu Popa <liviu-constantin.popa@ing.com>
@lcpopa
Fix conflict
c1cf485 
Signed-off-by: Liviu Popa <liviu-constantin.popa@ing.com>
@lcpopa
Merge branch 'master' of https://github.com/odpi/egeria
4a116f1
@lcpopa
Fix conflict
6610cfd 
Signed-off-by: Liviu Popa <liviu-constantin.popa@ing.com>
@lcpopa lcpopa marked this pull request as ready for review January 20, 2022 11:36
@lcpopa lcpopa requested a review from mandy-chessell January 20, 2022 11:40
@lcpopa
Copy link
Contributor Author

lcpopa commented Jan 20, 2022

Implemented requested changes

@pmarius22 pmarius22 enabled auto-merge January 25, 2022 10:12
@lcpopa lcpopa dismissed mandy-chessell’s stale review January 25, 2022 10:18

requested changes have been implemented

@pmarius22 pmarius22 merged commit d3639d7 into odpi:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdan-sava bogdan-sava bogdan-sava approved these changes

@pmarius22 pmarius22 pmarius22 approved these changes

@cmgrote cmgrote Awaiting requested review from cmgrote

@lpalashevski lpalashevski Awaiting requested review from lpalashevski

@davidradl davidradl Awaiting requested review from davidradl

@popa-raluca popa-raluca Awaiting requested review from popa-raluca

@alexandra-bucur alexandra-bucur Awaiting requested review from alexandra-bucur

@mandy-chessell mandy-chessell Awaiting requested review from mandy-chessell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AnchorClassification created on get
5 participants
@lcpopa @mandy-chessell @bogdan-sava @pmarius22 @planetf1