Remove entity proxy validation on classify/reclassify/declassify #6287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…peer-duplicates
…peer-duplicates
…peer-duplicates
Signed-off-by: Raluca Popa <raluca.popa2@ing.com>
Signed-off-by: Raluca Popa <raluca.popa2@ing.com>
lcpopa
approved these changes
Mar 4, 2022
|
I agree - lets update the original methods in the security connector to pass EntitySummary on the classification methods. |
mandy-chessell
requested changes
Mar 8, 2022
…cations � Conflicts: � open-metadata-implementation/common-services/generic-handlers/src/main/java/org/odpi/openmetadata/commonservices/generichandlers/OpenMetadataAPIGenericHandler.java
Signed-off-by: Raluca Popa <raluca.popa2@ing.com>
Signed-off-by: Raluca Popa <raluca.popa2@ing.com>
Signed-off-by: Raluca Popa <raluca.popa2@ing.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR covers two issues:
The previous validation was retrieving the entityDetail of an entity, that was later used in the validation methods of the securityVerifier.
With these changes the entitySummary of an entity is used instead. I created new methods in the securityVerifier classes, that use EntitySummary as a parameter instead of EntityDetail, but I was wondering if it would be better to modify the existing methods. @mandy-chessell , any thoughts on this?
Fixes # (issue)
How Has This Been Tested?
Tested locally with the setup for the deduplication.
Any additional notes for reviewers?