Add InvalidParameterHandler to all repository iterators to manage paging #6342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…no more entities when cache empty Signed-off-by: Alexandra Bucur <alexandra-nona.bucur@ing.com>
added 2 commits
March 25, 2022 17:25
Signed-off-by: Alexandra Bucur <alexandra-nona.bucur@ing.com>
alexandra-bucur
changed the title
…ormatting fixes Signed-off-by: Alexandra Bucur <alexandra-nona.bucur@ing.com>
mandy-chessell
previously requested changes
Mar 28, 2022
...andlers/src/main/java/org/odpi/openmetadata/commonservices/generichandlers/AssetHandler.java
Outdated
Show resolved
Hide resolved
...rs/src/main/java/org/odpi/openmetadata/commonservices/generichandlers/ConnectionHandler.java
Outdated
Show resolved
Hide resolved
...java/org/odpi/openmetadata/commonservices/generichandlers/OpenMetadataAPIGenericHandler.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/odpi/openmetadata/commonservices/repositoryhandler/RepositoryHandler.java
Outdated
Show resolved
Hide resolved
.../org/odpi/openmetadata/commonservices/repositoryhandler/RepositoryRelationshipsIterator.java
Outdated
Show resolved
Hide resolved
...g/odpi/openmetadata/commonservices/repositoryhandler/RepositorySelectedEntitiesIterator.java
Outdated
Show resolved
Hide resolved
added 3 commits
March 29, 2022 10:53
…e specific formatting fixes Signed-off-by: Alexandra Bucur <alexandra-nona.bucur@ing.com>
Signed-off-by: Alexandra Bucur <alexandra-nona.bucur@ing.com>
lcpopa
approved these changes
Mar 31, 2022
alexandra-bucur
dismissed
mandy-chessell’s stale review
I resolved the requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added the InvalidParameterHandler to all iterators (for both entities and relationships) in order to address the paging issue (infinite looping if page size was 0).
How Has This Been Tested?
Manually, with Asset Catalog, requesting asset context for a few entities + FVTs