Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6335 incompatible URLs on data-manager's DisplayApplicationResource #6343

Merged
merged 2 commits into from
Apr 12, 2022

Conversation

ykrkn
Copy link
Contributor

@ykrkn ykrkn commented Mar 24, 2022

No description provided.

@ykrkn ykrkn requested a review from mandy-chessell as a code owner March 24, 2022 13:13
…nResource

Signed-off-by: Yury Krikun <yury.krikun@gmail.com>
@davidradl
Copy link
Member

From @mandy-chessell comment in the issue - this is still being developed.
I suggest we wait until she has finished development.
I notice that server side
@PostMapping(path = "/data-containers/{dataContainerGUID}")
@PostMapping(path = "/data-containers/by-search-string")
@PostMapping(path = "/data-containers/by-name")

these appear to clash on the url.

Also the client still references elements in its calls.

@mandy-chessell
Copy link
Contributor

Looking at the code - changes need to be made to the server side to add the type name parameter to the method signature for both getDataContainerByName and findDataContainers. The implementation for getDataContainerParent is completely missing. I would suggest merging this PR since it fixes many of the URLs and the ones that still won't work are no worse than they were before. updateDataContainer looks ok

@mandy-chessell mandy-chessell merged commit 24c5ee3 into odpi:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants