Add ability to override AL OMAS topic listener connection properties #6900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raluca Popa <raluca.popa2@ing.com>
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
...i/openmetadata/governanceservers/openlineage/admin/OpenLineageServerOperationalServices.java
Outdated
Show resolved
Hide resolved
|
In addition further improvement: I do not like that initializeOLS call is blocking until the configuration is retrieved from the paired omas. This enforces certain deploy time rules and it is not optimal for containerized deployments. |
lpalashevski
requested changes
Sep 26, 2022
...va/org/odpi/openmetadata/adminservices/configuration/properties/OpenLineageServerConfig.java
Outdated
Show resolved
Hide resolved
...va/org/odpi/openmetadata/adminservices/configuration/properties/OpenLineageServerConfig.java
Outdated
Show resolved
Hide resolved
...va/org/odpi/openmetadata/adminservices/configuration/properties/OpenLineageServerConfig.java
Outdated
Show resolved
Hide resolved
...i/openmetadata/governanceservers/openlineage/admin/OpenLineageServerOperationalServices.java
Outdated
Show resolved
Hide resolved
...i/openmetadata/governanceservers/openlineage/admin/OpenLineageServerOperationalServices.java
Show resolved
Hide resolved
Signed-off-by: Raluca Popa <raluca.popa2@ing.com>
…ct in the embeddedConnections retrieved Signed-off-by: Raluca Popa <raluca.popa2@ing.com>
...i/openmetadata/governanceservers/openlineage/admin/OpenLineageServerOperationalServices.java
Outdated
Show resolved
Hide resolved
|
|
Signed-off-by: Raluca Popa <raluca.popa2@ing.com>
lpalashevski
approved these changes
Sep 29, 2022
Signed-off-by: Raluca Popa <raluca.popa2@ing.com>
popa-raluca
requested review from
marius-patrascu and
mandy-chessell
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Raluca Popa raluca.popa2@ing.com
Description
This PR change the asset lineage topic connection auto-configuration processing to allow configuration properties overrides.
The connection object will be still retrieved from the paired OMAS (as defined in the "accessServiceConfig")
once the connection object is retrieved we check if "assetLineageTopicConnectionOverride" object is present in local server configuration we will override the configuraionProperties received with the local values (map)
if the "assetLineageTopicConnectionOverride" object is not present in the local configuration then everything stays as it is (connection is created based on the parameters received from the remote access server)
Related Issue(s)
Testing
Release Notes & Documentation
Additional notes