Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7229 do not create a 2nd unneeded default audit log destination, when adding an audit log destination #7312

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

davidradl
Copy link
Member

#7229 the admin call to add an auditlog will add 2 audit log destinations if there is no RepositoryServicesConfig defined.

Description

I have added an overloaded method to create the default omrs configuration, the flag allows RepositoryServicesConfig to be created without a default audit log, so that in the add Audit log calling code can add the requested audit log and not end up with 2 destinations

After this change, we don't add the default audit log destination during construction when we are about to add an audit destination

Related Issue(s)

#7229

Testing

Manual testing

Release Notes & Documentation

Additional notes

@davidradl davidradl self-assigned this Jan 10, 2023
@davidradl davidradl changed the title Git7229 #7229 do not create a 2nd unneeded default audit log destination, when adding an audit log destination Jan 10, 2023
@davidradl davidradl merged commit 400f94e into odpi:main Jan 10, 2023
@mandy-chessell
Copy link
Contributor

@davidradl This fix needs to be reversed as it is not the correct behaviour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants