Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7413 ensure spring boot applications are packaged as primary jar in … #7417

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

planetf1
Copy link
Member

…maven publish artifacts

Description

  • Fixes missing spring boot jar in ui-chassis-spring & server-chassis spring published maven artifacts
  • the specific component jar is left in-situ with a classifier 'plain' (default sprintboot behaviour)

Related Issue(s)

Fixes #7413

Testing

Ran a build and checked artifacts ie:

➜  egeria ls -la ./server-chassis-spring/4.0-SNAPSHOT
total 164464
drwxr-xr-x  9 jonesn  staff       288 21 Feb 17:30 .
drwxr-xr-x  7 jonesn  staff       224  6 Feb 08:32 ..
-rw-r--r--  1 jonesn  staff      1287 21 Feb 17:41 maven-metadata-local.xml
-rw-r--r--  1 jonesn  staff    104102 21 Feb 17:41 server-chassis-spring-4.0-SNAPSHOT-javadoc.jar
-rw-r--r--  1 jonesn  staff     18225 21 Feb 17:26 server-chassis-spring-4.0-SNAPSHOT-plain.jar
-rw-r--r--  1 jonesn  staff     14151 21 Feb 17:41 server-chassis-spring-4.0-SNAPSHOT-sources.jar
-rw-r--r--  1 jonesn  staff  70904792 21 Feb 17:41 server-chassis-spring-4.0-SNAPSHOT.jar
-rw-r--r--  1 jonesn  staff     39622 21 Feb 17:41 server-chassis-spring-4.0-SNAPSHOT.module
-rw-r--r--  1 jonesn  staff     38738 21 Feb 17:41 server-chassis-spring-4.0-SNAPSHOT.pom
➜  egeria ls -la ./user-interface-spring/4.0-SNAPSHOT
ls: ./user-interface-spring/4.0-SNAPSHOT: No such file or directory
➜  egeria ls -la ./ui-chassis-spring/4.0-SNAPSHOT
total 94128
drwxr-xr-x  9 jonesn  staff       288 21 Feb 17:41 .
drwxr-xr-x  7 jonesn  staff       224  6 Feb 08:33 ..
-rw-r--r--  1 jonesn  staff      1283 21 Feb 17:41 maven-metadata-local.xml
-rw-r--r--  1 jonesn  staff    506142 21 Feb 17:41 ui-chassis-spring-4.0-SNAPSHOT-javadoc.jar
-rw-r--r--  1 jonesn  staff    185071 21 Feb 17:30 ui-chassis-spring-4.0-SNAPSHOT-plain.jar
-rw-r--r--  1 jonesn  staff    128619 21 Feb 17:41 ui-chassis-spring-4.0-SNAPSHOT-sources.jar
-rw-r--r--  1 jonesn  staff  47262288 21 Feb 17:41 ui-chassis-spring-4.0-SNAPSHOT.jar
-rw-r--r--  1 jonesn  staff     34607 21 Feb 17:41 ui-chassis-spring-4.0-SNAPSHOT.module
-rw-r--r--  1 jonesn  staff     34025 21 Feb 17:41 ui-chassis-spring-4.0-SNAPSHOT.pom

Also checked the other artifacts with uber jars. They are fine but were created with Shadow not SpringBoot.

See https://stackoverflow.com/questions/61197984/bootjar-mavenjar-artifact-wasnt-produced-by-this-build for an explanation. I had expected spring boot's default behaviour to work, but had not fully checked the actual maven artifacts only the jar build.

Release Notes & Documentation

Additional notes

… in maven publish artifacts

Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
@lpalashevski lpalashevski merged commit 9e0dabf into odpi:main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] v4 Gradle build does not publish spring boot fat jars
2 participants