Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Metadata Explorer OMVS and external identifiers to Automated Curation OMVS #8505

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

mandy-chessell
Copy link
Contributor

Description

This PR includes a number of changes:

  • There are new search methods in Metadata Explorer OMVS. This provides a comprehensive search facility for open metadata.
  • There are new methods in Automated Curation OMVS to both maintain and query information about external identifiers from third parties and their associated open metadata elements.
  • The Asset Manager OMAS methods for managing external identifiers have been removed and Asset Manager now uses the governance action framework methods
  • The governance action framework methods for managing external identifiers now consistently support effectivity dates, forLineage and forDuplicateProcessing.
  • Many of the iterators have been removed from the generic handlers so that paging information passes directly from the external caller to the underlying repositories. (The iterators always started from 0 and discarded anything retrieved up to the startFrom. This meant that paging through large collections was inefficient.)

Related Issue(s)

One of the FVTs from Governance Server OMVS that manages deduplication is no longer working - it is commented out and will be addressed in a future PR.

Testing

Basic regression test. The aim is to make the new OMVS function available to allow the pyegeria functions to be built. The real testing will happen through pyegeria.

Release Notes & Documentation

Descriptions of Metadata Explorer OMVS are in place. Wrok still needs to be don on the external identifiers documentation for Automated Curation OMVS.

Additional notes

None

…tion OMVS

Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>
@mandy-chessell mandy-chessell merged commit 86ed7ae into odpi:main Nov 29, 2024
4 checks passed
@@ -1566,7 +1571,7 @@
int startingEnd,
int startFrom,
int pageSize,
EffectiveTimeRequestBody requestBody)
ResultsRequestBody requestBody)

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'requestBody' is never used.
* @throws PropertyServerException there is a problem accessing the metadata store
*/
@Override
public List<OpenMetadataRelationship> getRelationshipHistory(String userId,

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
MetadataElementInterface.createMetadataElementInStore
; it is advisable to add an Override annotation.
boolean forDuplicateProcessing,
long effectiveTime)
public OpenMetadataRelationshipResponse getRelationshipByGUID(String serverName,
String serviceURLMarker,

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'serviceURLMarker' is never used.
String serviceURLMarker,
String userId,
String relationshipGUID,
boolean forLineage,

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'forLineage' is never used.
String userId,
String relationshipGUID,
boolean forLineage,
boolean forDuplicateProcessing,

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'forDuplicateProcessing' is never used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant