Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back subcomponent error flags #682

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Add back subcomponent error flags #682

merged 1 commit into from
Apr 5, 2022

Conversation

samuelsadok
Copy link
Member

These flags were previously removed in 5661a3b

@samuelsadok samuelsadok requested a review from madcowswe March 30, 2022 16:17
@szeder
Copy link
Contributor

szeder commented Apr 2, 2022

The commit reference included in the log message points to a non-existing commit, because the object name is missing its first hexdigit; it should be 5661a3b (Refactor control loop., 2020-09-01).

Anyway, as I was recently considering configuring an error_gpio_pin and hook it up to the microcontroller controlling the ODrive, I think bringing back subcomponent error flags is a good idea.

These flags were previously removed in 5661a3b
@samuelsadok
Copy link
Member Author

@szeder you're right, thanks! Fixed now.

@samuelsadok samuelsadok merged commit daa089c into devel Apr 5, 2022
@samuelsadok samuelsadok deleted the error-flags branch April 5, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants