Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes 0.2.7 #118

Merged
merged 9 commits into from
May 8, 2024
Merged

Bug fixes 0.2.7 #118

merged 9 commits into from
May 8, 2024

Conversation

sabinem
Copy link
Contributor

@sabinem sabinem commented May 7, 2024

This PR adds bug fixes for v.0.2.7:

  • select forms no longer log errors when the value in the form did not change
  • the component add form has now a proper validation of the github url

@sabinem
perf: log calls to the github api
f1d5562 
in the dashboard these calls sometimes slow down performance in
case there are too many of them, therefore it seems good to log
these calls
@sabinem
fix: set log level to debug by default
d147592
@sabinem
refactor(github validator): make validator into a normal validator
60638eb 
in the dashboard the validation on autocomplete can be disabled
therefore it is no longer necessary to check for the validity
of the github url in the way it was previously implemented
@sabinem
fix(dashboard compoents page): improve validation and fix bugs
355760d 
the validation of the github url when a component is added has
been improved
@sabinem
feat(dashboard utils): add helper function to check ui.select
40fa4e6 
check whether the value in ui select has changed, since otherwise
the selection must not be stored in the users internal storage
@sabinem
fix(dashboard: select forms): use custom function to check change
41fd856 
use a function that checks whether the value in a select form has
changed and must be saved
@sabinem
style: add blank line at the end of the file
0b8c29f
@sabinem
fix: but file picking into try except block
3a1e692 
that way some common errors can be handled in a better way: such
as when no file was picked or when the file could not be parsed
caviri
caviri approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@caviri caviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool @sabinem

@sabinem sabinem merged commit 20145bb into main May 8, 2024
@sabinem sabinem deleted the bug-fixes-0.2.7 branch June 19, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caviri caviri caviri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabinem @caviri