Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dashboard components #97

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Improve dashboard components #97

merged 1 commit into from
Apr 22, 2024

Conversation

sabinem
Copy link
Contributor

@sabinem sabinem commented Apr 22, 2024

This PR improves the management of Components in the dashboard:

  • only tagged versions of components can be added: the commit is then directly taken from the tagged version on github
  • it is visibly distinguished between info coming from github and info coming from odtp
  • users are offered to add all versions of a component that are new on github, but not yet available on odtp.
  • the workflow to add new versions for a component had some bugs that have now been adressed
  • all forms have now validation, to make sure components and versions are all added correctly

@sabinem sabinem changed the title Improve dashboard components Draft: Improve dashboard components Apr 22, 2024
@sabinem sabinem force-pushed the improve-dashboard-components branch from 5e3bdc9 to 4fe31b5 Compare April 22, 2024 09:23
@sabinem sabinem changed the title Draft: Improve dashboard components Improve dashboard components Apr 22, 2024
@sabinem sabinem mentioned this pull request Apr 22, 2024
Merged
@sabinem sabinem changed the base branch from main to develop April 22, 2024 10:18
refactor(dashboard:components)
73df213 
improve management of components in the dashboard:
- only component versions that have been tagged can be added
- the commits will be directly taken from the tagged versions
- the overall flow has been improved
- bugs have been remove (they were related to storage handling)
@sabinem sabinem force-pushed the improve-dashboard-components branch from 4fe31b5 to 73df213 Compare April 22, 2024 11:34
@caviri
Copy link
Contributor

caviri commented Apr 22, 2024

Hello @sabinem, looks good to me! :)

@sabinem sabinem merged commit 12f3475 into develop Apr 22, 2024
@sabinem sabinem deleted the improve-dashboard-components branch May 7, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caviri caviri caviri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabinem @caviri