Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow URI input form on replay to work without JS #414

Closed
machawk1 opened this issue Jul 3, 2018 · 2 comments
Closed

Allow URI input form on replay to work without JS #414

machawk1 opened this issue Jul 3, 2018 · 2 comments

Comments

@machawk1
Copy link
Member

machawk1 commented Jul 3, 2018

Per #412, we added a button to submit the form, which previously relied on hitting enter with a text field in focus. The conventional submission mechanism is currently suppressed via JS and handled via JS.

This should be more accessible. @ibnesayeed provided a mechanism to accomplish this in #412.

@ibnesayeed
Copy link
Member

Direct link to the related comment #412 (comment).

@machawk1
Copy link
Member Author

machawk1 commented Jul 4, 2018

Added a fix for this in b0108ef and tested without JS.

When /memento/*/?url=foo.com was requested, the normal handler showMementosForURIRs(urir) with route /memento/*/<path:urir> is not called due to the path: requirement specification. Instead, show_uri(path, datetime=None) would be called with the more generic route.

Creating a path-less route of simply /memento/*/ then reading the query string and performing a redirect to showMementosForURIRs(urir) proved sufficient for reusing the function/route.

machawk1 added a commit that referenced this issue Jul 4, 2018
Allow replay text form to function without JS, closes #414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants