Version is not reported on CLI

[ibnesayeed]

Neither -v not --version flags seem to be working.

$ ipwb -v
usage: ipwb [-h] [-d DAEMON_ADDRESS] [-o OUTFILE] [-v] {index,replay} ...

InterPlanetary Wayback (ipwb)

optional arguments:
  -h, --help            show this help message and exit
  -d DAEMON_ADDRESS, --daemon DAEMON_ADDRESS
                        Location of ipfs daemon (default 127.0.0.1:5001)
  -o OUTFILE, --outfile OUTFILE
                        Filename of newly created CDXJ index file
  -v, --version         Report the version of ipwb

ipwb commands:
  Invoke using "ipwb <command>", e.g., ipwb replay

  {index,replay}
    index               Index a WARC file for replay in ipwb
    replay              Start the ipwb replay system

[machawk1]

Odd. I can replicate this bug. Maybe something is shadowing it from when we changed the replay and indexing sub-argparsing.

[ibnesayeed]

This time a test would be easy to write for this one I guess.

[machawk1]

Good call but the version number will change and it's probably best that we don't have to maintain the test based on the version. Should we check for a string like "InterPlanetary Wayback v." in the output? Regex?

Let's use this ticket for a test-driven resolution with it failing once we create the test then resolved with the eventual PR.

[machawk1]

In __main__.py:

def checkArgs(argsIn):
  argCount = len(argsIn)
  cmdList = ['index', 'replay']
  ...
  cmdError_invalidCommand = argCount > 1 and argsIn[1] not in cmdList
  if cmdError_noCommand or cmdError_invalidCommand:
        parser.print_help()

With ipwb -v, argsIn is ['/usr/local/bin/ipwb', '-v']

[ibnesayeed]

Good call but the version number will change and it's probably best that we don't have to maintain the test based on the version. Should we check for a string like "InterPlanetary Wayback v." in the output? Regex?

The point is, you don't make your test too rigid, but not too loose either. Just test what you expect to be there, be it a pattern, a prefix, or something else.