Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plurality issue in the URI listing in the replay UI #534

Closed
machawk1 opened this issue Aug 27, 2018 · 1 comment
Closed

Plurality issue in the URI listing in the replay UI #534

machawk1 opened this issue Aug 27, 2018 · 1 comment
Assignees
@machawk1
Labels
ipwb replay UI/UX/Accessibility

Comments

@machawk1
Copy link
Member

screen shot 2018-08-27 at 11 57 17 am

It should be "1 memento of 1 resources with 0 HTML pages listed"
@machawk1 machawk1 self-assigned this Aug 27, 2018
@machawk1
Copy link
Member Author

With the new templating system, we may want to move the logic in setPlurality() (JS) to attributes of the showLandingPage() in replay.py. This should make these values display more consistently regardless of the client's JS rendering.

@machawk1 machawk1 mentioned this issue Aug 27, 2018
Merged
machawk1 added a commit that referenced this issue Aug 27, 2018
@machawk1
Merge pull request #535 from oduwsdl/issue-534
4d09ed3 
[WIP] Fix plurality of mementos and resources on main replay page. Closes #534
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@machawk1 machawk1

Labels
ipwb replay UI/UX/Accessibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@machawk1