Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve static assets under /ipwbassets from a directory #529

Merged
merged 7 commits into from
Aug 27, 2018
Merged

Conversation

ibnesayeed
Copy link
Member

@ibnesayeed ibnesayeed commented Aug 27, 2018

As per #528 adding a new route /ipwbassets/<path:path> and serving all the static assets from there. Some resources have already been moved to it and gradually we will get rid of the WebUI route and folder along with all the associated code in replay. When merged, close #528.

@codecov
Copy link

codecov bot commented Aug 27, 2018

Codecov Report

Merging #529 into master will increase coverage by 0.51%.
The diff coverage is 21.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #529      +/-   ##
==========================================
+ Coverage    23.3%   23.81%   +0.51%     
==========================================
  Files           6        6              
  Lines        1163     1138      -25     
  Branches      174      167       -7     
==========================================
  Hits          271      271              
+ Misses        875      850      -25     
  Partials       17       17
Impacted Files Coverage Δ
setup.py 0% <ø> (ø) ⬆️
ipwb/replay.py 14.35% <21.42%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d533d4...d7a8cde. Read the comment docs.

@ibnesayeed
Copy link
Member Author

Now we got rid of the /webui route and corresponding folder while utilizing recently added asset serving endpoint. We have also moved index.html to templates and no longer performing find and replace.

Copy link
Member

@machawk1 machawk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and all LGTM

@machawk1 machawk1 merged commit 4f28a50 into master Aug 27, 2018
@machawk1 machawk1 deleted the issue-528 branch August 27, 2018 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serve static assets from a directory
2 participants