-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serve static assets under /ipwbassets from a directory #529
Conversation
Codecov Report
@@ Coverage Diff @@
## master #529 +/- ##
==========================================
+ Coverage 23.3% 23.81% +0.51%
==========================================
Files 6 6
Lines 1163 1138 -25
Branches 174 167 -7
==========================================
Hits 271 271
+ Misses 875 850 -25
Partials 17 17
Continue to review full report at Codecov.
|
Now we got rid of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and all LGTM
As per #528 adding a new route
/ipwbassets/<path:path>
and serving all the static assets from there. Some resources have already been moved to it and gradually we will get rid of the WebUI route and folder along with all the associated code in replay. When merged, close #528.