Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds fall-through for setting locale to fix ipwb on Android #619

Merged
merged 2 commits into from
Jul 29, 2019

Conversation

machawk1
Copy link
Member

Fixes #602

@codecov
Copy link

codecov bot commented Jul 29, 2019

Codecov Report

Merging #619 into master will increase coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #619      +/-   ##
==========================================
+ Coverage   24.37%   24.39%   +0.02%     
==========================================
  Files           6        6              
  Lines        1231     1234       +3     
  Branches      185      185              
==========================================
+ Hits          300      301       +1     
- Misses        907      909       +2     
  Partials       24       24
Impacted Files Coverage Δ
ipwb/util.py 35.21% <50%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 753af60...9fd82fa. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jul 29, 2019

Codecov Report

Merging #619 into master will increase coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #619      +/-   ##
==========================================
+ Coverage   24.37%   24.39%   +0.02%     
==========================================
  Files           6        6              
  Lines        1231     1234       +3     
  Branches      185      185              
==========================================
+ Hits          300      301       +1     
- Misses        907      909       +2     
  Partials       24       24
Impacted Files Coverage Δ
ipwb/util.py 35.21% <50%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 753af60...9fd82fa. Read the comment docs.

@machawk1
Copy link
Member Author

Yeah, yeah, this violates DRY but I can't seem to find a better way to detect Android and this is a safer default for any misc systems that don't have one of the pre-defined locales available.

@machawk1 machawk1 merged commit a9060cb into master Jul 29, 2019
@machawk1 machawk1 deleted the linuxlocale branch July 29, 2019 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported locale on Android
1 participant