Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mechanism for generating a temporary cdxj file. #697

Merged
merged 2 commits into from
Jul 10, 2020

Conversation

machawk1
Copy link
Member

Closes #696

@machawk1 machawk1 requested a review from ibnesayeed July 10, 2020 16:09
@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #697 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #697      +/-   ##
==========================================
- Coverage   29.26%   29.23%   -0.03%     
==========================================
  Files          10       10              
  Lines        1244     1245       +1     
  Branches      184      184              
==========================================
  Hits          364      364              
- Misses        857      858       +1     
  Partials       23       23              
Impacted Files Coverage Δ
ipwb/__main__.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b2805...8d16c1e. Read the comment docs.

ipwb/__main__.py Outdated Show resolved Hide resolved
@machawk1 machawk1 requested a review from ibnesayeed July 10, 2020 18:40
Copy link
Member

@ibnesayeed ibnesayeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@machawk1 machawk1 merged commit 58d9572 into master Jul 10, 2020
@machawk1 machawk1 deleted the issue-696-sans-tests branch July 10, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Temporary CDXJ files are not found by replay
2 participants