Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark mode CSS, improve accessibility #708

Merged
merged 3 commits into from
Jul 24, 2020
Merged

Add dark mode CSS, improve accessibility #708

merged 3 commits into from
Jul 24, 2020

Conversation

machawk1
Copy link
Member

Adds an initial set of style for the replay UI to be adaptive to
dark mode. This also moves to use the version of the logo with
the light border that is only apparent in dark mode. The kerning,
coincidentally, is better in this version than the version that
has been used in the replay UI.

Some other tweaks have also been applied to improve the
accessibility including some markup additions and adjustments.

This PR consists of just some initial style for dark mode, and
could use some further tweaking, but it should meet the requirements
of #695 in making the UI slightly adaptive.

Closes #695

Adds an initial set of style for the replay UI to be adaptive to
dark mode. This also moves to use the version of the logo with
the light border that is only apparent in dark mode. The kerning,
coincidentally, is better in this version than the version that
has been used in the replay UI.

Some other tweaks have also been applied to improve the
accessibility including some markup additions and adjustments.

This PR consists of just some initial style for dark mode, and
could use some further tweaking, but it should meet the requirements
of #695 in making the UI slightly adaptive.

Closes #695
@machawk1 machawk1 requested a review from ibnesayeed July 24, 2020 16:28
@machawk1 machawk1 changed the title Add dark mode CSS, improve accessibility. Add dark mode CSS, improve accessibility Jul 24, 2020
@machawk1
Copy link
Member Author

For reference, some screenshot that, again, can tweaked.

Screen Shot 2020-07-24 at 12 24 14 PM
Screen Shot 2020-07-24 at 12 24 07 PM

@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #708 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #708   +/-   ##
=======================================
  Coverage   29.24%   29.24%           
=======================================
  Files          10       10           
  Lines        1248     1248           
  Branches      185      185           
=======================================
  Hits          365      365           
  Misses        860      860           
  Partials       23       23           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c1c690...3f02f09. Read the comment docs.

@machawk1
Copy link
Member Author

One other adjustment while I was tweaking CSS, the "URIs" abbreviation underline is broken per the default browser style and the U apparently being a descender. I tweaked this in b6d33f2.

Before:
Screen Shot 2020-07-24 at 12 44 42 PM
After (per b6d33f2):
Screen Shot 2020-07-24 at 12 44 04 PM

Copy link
Member

@ibnesayeed ibnesayeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS file does not have a trailing new line, other than that LGTM!

ipwb/assets/webui.css Outdated Show resolved Hide resolved
Co-authored-by: Sawood Alam <ibnesayeed@gmail.com>
@machawk1 machawk1 merged commit 8504086 into master Jul 24, 2020
@machawk1 machawk1 deleted the issue-695 branch July 24, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a dark mode for replay UI
2 participants