Add a third motivating example and pre-commit example #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maintainers of
pip
have been working behind the scenes (pypa/pip#8437 (comment)) to add build isolation configurations to newer versions. This uses aproject.toml
file to ensure configuration information is provided in a scripted way, but was co-opted by the developers of Flake8 and Black before it could realistically be used for pip-only applications. As a result, if aproject.toml
file exists in a repository for the purposes of configuringBlack
it will force pip to use the more locked down build process and will cause various issues like import failures in setup.py. The natural solution is to move to the most standardizedsetup.cfg
file for Black, but the maintainers refused to allow this option. Luckily, your project allows exactly this feature. I've added a third motivating example to your list to highlight this issue and provide a more direct link for people who are looking to jump ship from Black's stubbornness.I've also added a description on how to do a drop-in-replacement from Black to Brunette as used by pre-commit.
Finally, I had a developer friend comment on the somewhat sensitive/risky naming convention by using the term brunette. I'm sure that this was an innocent play on words, but explaining that explicitly in the READMe with an added anti-gender-discrimination discussion may help to reassure collaborators.(Removed per request of maintainer)