Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATNA Auditing - ITI-55 Missing PurposeOfUse #413

Closed
zortx233 opened this issue Apr 21, 2023 · 2 comments
Closed

ATNA Auditing - ITI-55 Missing PurposeOfUse #413

zortx233 opened this issue Apr 21, 2023 · 2 comments
Assignees
Milestone

Comments

@zortx233
Copy link

Hello,

I was playing with the ATNA auditing for XCPD, ITI-55, and noticed the PurposeOfUse I passed in my SAML attributes wasn't getting logged.

It looks like in Iti55AuditStrategy.groovy, in the method makeAuditMessage the fourth argument to new QueryInformationBuilder where it passes PurposeOfUse is missing.

Current Code

AuditMessage[] makeAuditMessage(AuditContext auditContext, Hl7v3AuditDataset auditDataset) {
        QueryInformationBuilder builder = new QueryInformationBuilder<>(auditContext, auditDataset, Hl7v3EventTypeCode.CrossGatewayPatientDiscovery)

Fixed Code
new QueryInformationBuilder<>(auditContext, auditDataset, Hl7v3EventTypeCode.CrossGatewayPatientDiscovery, auditDataset.purposesOfUse)

I verified locally after I added the fourth argument to pass auditDataset.purposesOfUse, that the PurposeOfUse element does show up in the EventIdentification XML element.

@unixoid unixoid self-assigned this Apr 22, 2023
unixoid added a commit that referenced this issue Apr 22, 2023
@unixoid
Copy link
Member

unixoid commented Apr 22, 2023

@zortx233 Thank you for reporting and providing a solution. I applied your patch and also found two more transactions where it was necessary.

@unixoid
Copy link
Member

unixoid commented Apr 22, 2023

Side remark: It is not very good to pass both auditDataset and auditDataset.getPurposeOfUse() to constructors of QueryInformationBuilder and its siblings, but a proper refactoring would require too much effort now. Let us wait till the IHE audit trail will be rebased onto FHIR, and then simply throw away the legacy DICOM-related code ;-)

@unixoid unixoid closed this as completed Apr 22, 2023
@Thopap Thopap added this to the IPF 4.7.0 milestone Apr 24, 2023
stanojevic-boris pushed a commit that referenced this issue May 9, 2023
@Thopap Thopap modified the milestones: IPF 4.7.0, IPF 4.6.1 May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants