Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desalination model #5

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Desalination model #5

wants to merge 22 commits into from

Conversation

FranziPl
Copy link
Collaborator

This PR will add the second solar model to the repo, the desalination model. The structure is similar to the forst one, the solar cooling. The requirements are also valid for both.

@FranziPl FranziPl mentioned this pull request Sep 29, 2020
@FranziPl FranziPl self-assigned this Sep 29, 2020
Copy link
Member

@c-moeller c-moeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get an error, running the system:

Traceback (most recent call last):
  File "desalination_main.py", line 16, in <module>
    from desalination_precalculation import run_precalculation
ModuleNotFoundError: No module named 'desalination_precalculation'

desalination/README.md Outdated Show resolved Hide resolved
desalination/README.md Outdated Show resolved Hide resolved
desalination/README.md Outdated Show resolved Hide resolved
desalination/src/desalination_main.py Outdated Show resolved Hide resolved
desalination/src/desalination_main.py Outdated Show resolved Hide resolved
FranziPl and others added 2 commits September 30, 2020 07:50
Co-authored-by: Caroline Möller <caroline.moeller@rl-institut.de>
@FranziPl
Copy link
Collaborator Author

I added the missing file, so the error shouldn't appear anymore. And I changed the code according to your suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants