Fix and update HeatPipeine classes / oemof_heatpipe.py #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following issues are addressed. Sorry for putting it all in this PR. This is a complete revision of
dhnx/optimization/oemof_heatpipe.py
Fix oemof network 0.5.0:
There were changes in oemof.network with the release 0.5.0, e.g. making function signatures explicit, that lead errors with the specific attributes of the HeatPipeline class, as the Heatpipeline class inherit from oemof.network Transformer.
An update of the initiation function solves the problem, and making the arguments explicit also makes things clearer.
Remove conversion factors:
These were only partly implemented and do not make sense in the component. If these are needed in some cases, we could properly add them again.
Fix docstrings:
The docstrings are not up to date.
Fix solph 0.5.1 (periods) for existing heatpipelines