Merge pull request #1069 from oemof/fix/update-branch_adapt-costs-for…

…-multi-year-periods_to_052ev1_and_fix

Update branch adapt-costs-for-multi-year-periods to v0.5.2.dev1

.bumpversion.cfg

@@ -1,5 +1,5 @@
 [bumpversion]
-current_version = 0.5.2dev0
+current_version = 0.5.2dev1
 commit = True
 tag = True
 

.readthedocs.yaml

@@ -1,13 +1,15 @@
 # See https://docs.readthedocs.io/en/stable/config-file/v2.html for details
 version: 2
 build:
+  os: ubuntu-22.04
+  tools:
+    python: "3.8"
   apt_packages:
     - coinor-cbc
 sphinx:
   configuration: docs/conf.py
 formats: []
 python:
-  version: "3.8"
   install:
     - requirements: docs/requirements.txt
     - method: pip

VERSION

@@ -1 +1 @@
-__version__ = "0.5.2dev0"
+__version__ = "0.5.2dev1"

docs/conf.py

@@ -36,7 +36,7 @@ def setup(app):
 year = "2014-2023"
 author = "oemof-developer-group"
 copyright = "{0}, {1}".format(year, author)
-version = release = "0.5.2dev0"
+version = release = "0.5.2dev1"
 
 pygments_style = "trac"
 templates_path = ["."]

docs/usage.rst

@@ -643,8 +643,8 @@ The following example pictures a Pumped Hydroelectric Energy Storage (PHES). Bot
 
     solph.components.GenericStorage(
         label='PHES',
-        inputs={b_el: solph.flows.Flow(investment= solph.Investment(ep_costs=500))},
-        outputs={b_el: solph.flows.Flow(investment= solph.Investment(ep_costs=500)},
+        inputs={b_el: solph.flows.Flow(nominal_value=solph.Investment(ep_costs=500))},
+        outputs={b_el: solph.flows.Flow(nominal_value=solph.Investment(ep_costs=500)},
         loss_rate=0.001,
         inflow_conversion_factor=0.98, outflow_conversion_factor=0.8),
         investment = solph.Investment(ep_costs=40))
@@ -912,7 +912,7 @@ turbines.
 
     solph.components.Source(label='new_wind_pp', outputs={electricity: solph.flows.Flow(
         fix=wind_power_time_series,
-	investment=solph.Investment(ep_costs=epc, maximum=50000))})
+	nominal_value=solph.Investment(ep_costs=epc, maximum=50000))})
 
 Let's slightly alter the case and consider for already existing wind power
 capacity of 20,000 kW. We're still expecting the total wind power capacity, thus we
@@ -922,7 +922,7 @@ allow for 30,000 kW of new installations and formulate as follows.
 
     solph.components.Source(label='new_wind_pp', outputs={electricity: solph.flows.Flow(
         fix=wind_power_time_series,
-	    investment=solph.Investment(ep_costs=epc,
+	    nominal_value=solph.Investment(ep_costs=epc,
 	                                maximum=30000,
 	                                existing=20000))})
 
@@ -957,7 +957,7 @@ example of a converter:
         label='converter_nonconvex',
         inputs={bus_0: solph.flows.Flow()},
         outputs={bus_1: solph.flows.Flow(
-            investment=solph.Investment(
+            nominal_value=solph.Investment(
                 ep_costs=4,
                 maximum=100,
                 minimum=20,
@@ -1004,8 +1004,8 @@ mathematical background, like variables and constraints, which are used.
 
 .. _multi_period_mode_label:
 
-Using the multi-period (investment) mode (experimental)
--------------------------------------------------------
+Multi-period (investment) mode (experimental)
+---------------------------------------------
 Sometimes you might be interested in how energy systems could evolve in the longer-term, e.g. until 2045 or 2050 to meet some
 carbon neutrality and climate protection or RES and energy efficiency targets.
 
@@ -1020,18 +1020,18 @@ only unfolds if you look at long-term investments. Let's see how.
 First, you start by defining your energy system as you might have done before, but you
 
 * choose a longer-term time horizon (spanning multiple years, i.e. multiple periods) and
-* explicitly define the `periods` attribute of your energy system which maps time steps to the simulated period.
+* explicitly define the `periods` attribute of your energy system which lists the time steps for each period.
 
 .. code-block:: python
 
     import pandas as pd
     import oemof.solph as solph
 
     my_index = pd.date_range('1/1/2013', periods=17520, freq='H')
-    periods = {
-        0: pd.date_range('1/1/2013', periods=8760, freq='H'),
-        1: pd.date_range('1/1/2014', periods=8760, freq='H'),
-    }
+    periods = [
+        pd.date_range('1/1/2013', periods=8760, freq='H'),
+        pd.date_range('1/1/2014', periods=8760, freq='H'),
+    ]
     my_energysystem = solph.EnergySystem(timeindex=my_index, periods=periods)
 
 If you want to use a multi-period model you have define periods of your energy system explicitly. This way,
@@ -1057,17 +1057,16 @@ and adjust to your needs:
 
         Returns
         -------
-        periods : dict
-            pd.date_ranges defining the time stamps for the respective period,
-            starting with period 0
+        periods : list
+            periods for the optimization run
         """
         years = sorted(list(set(getattr(datetimeindex, "year"))))
-        periods = {}
+        periods = []
         filter_series = datetimeindex.to_series()
         for number, year in enumerate(years):
             start = filter_series.loc[filter_series.index.year == year].min()
             end = filter_series.loc[filter_series.index.year == year].max()
-            periods[number] = pd.date_range(start, end, freq=datetimeindex.freq)
+            periods.append(pd.date_range(start, end, freq=datetimeindex.freq))
 
         return periods
 
@@ -1144,7 +1143,7 @@ Here is an example
         inputs={hydrogen_bus: solph.flows.Flow()},
         outputs={
             electricity_bus: solph.flows.Flow(
-                investment=solph.Investment(
+                nominal_value=solph.Investment(
                     maximum=1000,
                     ep_costs=1e6,
                     lifetime=30,
@@ -1178,7 +1177,7 @@ This would mean that for investments in the particular period, these values woul
         inputs={hydrogen_bus: solph.flows.Flow()},
         outputs={
             electricity_bus: solph.flows.Flow(
-                investment=solph.Investment(
+                nominal_value=solph.Investment(
                     maximum=1000,
                     ep_costs=[1e6, 1.1e6],
                     lifetime=30,
@@ -1269,6 +1268,13 @@ Besides the `invest` variable, new variables are introduced as well. These are:
     * You can specify periods of different lengths, but the frequency of your timeindex needs to be consistent. Also,
       you could use the `timeincrement` attribute of the energy system to model different weightings. Be aware that this
       has not yet been tested.
+    * For now, both, the `timeindex` as well as the `timeincrement` of an energy system have to be defined since they
+      have to be of the same length for a multi-period model.
+    * You can choose whether to re-evaluate assets at the end of the optimization horizon. If you set attribute
+      `use_remaining_value` of the energy system to True (defaults to False), this leads to the model evaluating the
+      difference in the asset value at the end of the optimization horizon vs. at the time the investment was made.
+      The difference in value is added to or subtracted from the respective investment costs increment,
+      assuming assets are to be liquidated / re-evaluated at the end of the optimization horizon.
     * Also please be aware, that periods correspond to years by default. You could also choose
       monthly periods, but you would need to be very careful in parameterizing your energy system and your model and also,
       this would mean monthly discounting (if applicable) as well as specifying your plants lifetimes in months.
@@ -1466,12 +1472,11 @@ This nonlinearity is linearised in the
         inputs={b_diesel: solph.flows.Flow()},
         outputs={
             b_el: solph.flows.Flow(
-                nominal_value=None,
                 variable_costs=0.04,
                 min=0.2,
                 max=1,
                 nonconvex=solph.NonConvex(),
-                investment=solph.Investment(
+                nominal_value=solph.Investment(
                     ep_costs=90,
                     maximum=150, # required for the linearization
                 ),

docs/whatsnew/v0-5-1.rst

@@ -23,8 +23,8 @@ New features
 
 * Add option to run multi-period (dynamic) investment models with oemof.solph as an experimental feature:
     * You can change from standard model to multi-period model by defining the newly introduced `periods`
-      attribute of your energy system. Be aware that it is experimental as of now. `periods` is a dictionary
-      mapping the periods you want to model (usually years) to pandas.date_range objects.
+      attribute of your energy system. Be aware that it is experimental as of now. `periods` is a list
+      of the periods you want to model (usually years) given as pandas.date_range objects.
     * Add attributes `periods` to :class:`oemof.solph._energy_system.EnergySystem`.
     * Introduce new Pyomo Sets `PERIODS` and `TIMEINDEX` in :class:`oemof.solph.models.Model`.
     * Index all investment-related variables with `PERIODS` and flow variable with `TIMEINDEX`, which

docs/whatsnew/v0-5-2.rst

@@ -4,15 +4,25 @@ v0.5.2 (????)
 API changes
 ###########
 
+* New bool attribute `use_remaining_value` of `oemof.solph.EnergySystem`
+
 New features
 ############
 
+* Allow for evaluating differences in the remaining vs. the original value
+  for multi-period investments.
+
 Documentation
 #############
 
 Bug fixes
 #########
 
+* Fix handling of investment annuities and fixed costs for multi-period models:
+  Limit to costs that occur within the optimization horizon to prevent a
+  bias towards investments happening earlier in the optimization horizon.
+* Fix bugs in multi-period documentation.
+
 Testing
 #######
 
@@ -25,3 +35,7 @@ Contributors
 ############
 
 * Patrik Schönfeldt
+* Johannes Kochems
+* Julian Endres
+* Hendrik Huyskens
+* Raul Ciria Aylagas

examples/electrical/lopf.py

@@ -151,7 +151,7 @@ def main():
             input=b_el0,
             output=b_el1,
             reactance=0.0001,
-            investment=Investment(ep_costs=10),
+            nominal_value=Investment(ep_costs=10),
             min=-1,
             max=1,
         )

examples/electrical/transshipment.py

@@ -144,8 +144,8 @@ def main():
             label="line_0",
             inputs={b_0: Flow(), b_1: Flow()},
             outputs={
-                b_1: Flow(investment=Investment()),
-                b_0: Flow(investment=Investment()),
+                b_1: Flow(nominal_value=Investment()),
+                b_0: Flow(nominal_value=Investment()),
             },
             conversion_factors={(b_0, b_1): 0.95, (b_1, b_0): 0.9},
         )

examples/generic_invest_limit/example_generic_invest.py

@@ -42,7 +42,7 @@
 
     .. literalinclude:: /../examples/generic_invest_limit/example_generic_invest.py
         :language: python
-        :lines: 62-219
+        :lines: 62-
 
 Installation requirements
 -------------------------
@@ -141,8 +141,7 @@ def main():
             inputs={bus_a_0: solph.Flow()},
             outputs={
                 bus_a_1: solph.Flow(
-                    nominal_value=None,
-                    investment=solph.Investment(
+                    nominal_value=solph.Investment(
                         ep_costs=epc_invest,
                         custom_attributes={"space": 2},
                     ),
@@ -159,8 +158,7 @@ def main():
             inputs={bus_b_0: solph.Flow()},
             outputs={
                 bus_b_1: solph.Flow(
-                    nominal_value=None,
-                    investment=solph.Investment(
+                    nominal_value=solph.Investment(
                         ep_costs=epc_invest,
                         custom_attributes={"space": 1},
                     ),

examples/invest_nonconvex_flow_examples/diesel_genset_nonconvex_investment.py

@@ -132,8 +132,7 @@ def main():
         outputs={
             b_el_dc: solph.flows.Flow(
                 fix=solar_potential / peak_solar_potential,
-                nominal_value=None,
-                investment=solph.Investment(
+                nominal_value=solph.Investment(
                     ep_costs=epc_pv * n_days / n_days_in_year
                 ),
                 variable_costs=0,
@@ -157,11 +156,10 @@ def main():
         inputs={b_diesel: solph.flows.Flow()},
         outputs={
             b_el_ac: solph.flows.Flow(
-                nominal_value=None,
                 variable_costs=variable_cost_diesel_genset,
                 min=min_load,
                 max=max_load,
-                investment=solph.Investment(
+                nominal_value=solph.Investment(
                     ep_costs=epc_diesel_genset * n_days / n_days_in_year,
                     maximum=2 * peak_demand,
                 ),
@@ -177,8 +175,7 @@ def main():
         label="rectifier",
         inputs={
             b_el_ac: solph.flows.Flow(
-                nominal_value=None,
-                investment=solph.Investment(
+                nominal_value=solph.Investment(
                     ep_costs=epc_rectifier * n_days / n_days_in_year
                 ),
                 variable_costs=0,
@@ -196,8 +193,7 @@ def main():
         label="inverter",
         inputs={
             b_el_dc: solph.flows.Flow(
-                nominal_value=None,
-                investment=solph.Investment(
+                nominal_value=solph.Investment(
                     ep_costs=epc_inverter * n_days / n_days_in_year
                 ),
                 variable_costs=0,
@@ -213,13 +209,14 @@ def main():
     epc_battery = 101.00  # currency/kWh/year
     battery = solph.components.GenericStorage(
         label="battery",
-        nominal_storage_capacity=None,
-        investment=solph.Investment(
+        nominal_storage_capacity=solph.Investment(
             ep_costs=epc_battery * n_days / n_days_in_year
         ),
         inputs={b_el_dc: solph.flows.Flow(variable_costs=0)},
         outputs={
-            b_el_dc: solph.flows.Flow(investment=solph.Investment(ep_costs=0))
+            b_el_dc: solph.flows.Flow(
+                nominal_value=solph.Investment(ep_costs=0)
+            )
         },
         initial_storage_level=0.0,
         min_storage_level=0.0,

examples/invest_nonconvex_flow_examples/house_with_nonconvex_investment.py

@@ -91,7 +91,7 @@ def heat_demand(d):
                     minimum_uptime=5,
                     initial_status=1,
                 ),
-                investment=solph.Investment(
+                nominal_value=solph.Investment(
                     ep_costs=epc,
                     minimum=1.0,
                     maximum=10.0,

examples/invest_nonconvex_flow_examples/house_without_nonconvex_investment.py

@@ -117,7 +117,7 @@ def solar_thermal(d):
         outputs={
             b_heat: solph.flows.Flow(
                 fix=[solar_thermal(day) for day in range(0, periods)],
-                investment=solph.Investment(
+                nominal_value=solph.Investment(
                     ep_costs=epc, minimum=1.0, maximum=5.0
                 ),
             )

examples/investment_with_minimal_invest/minimal_invest.py

@@ -86,8 +86,7 @@ def main():
         inputs={bus_0: solph.Flow()},
         outputs={
             bus_1: solph.Flow(
-                nominal_value=None,
-                investment=solph.Investment(
+                nominal_value=solph.Investment(
                     ep_costs=c_var,
                     maximum=p_install_max,
                     minimum=p_install_min,